Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove duplicate hostname resource attribute #1581

Merged
merged 2 commits into from
Oct 9, 2020

Conversation

mwear
Copy link
Member

@mwear mwear commented Oct 8, 2020

Which problem is this PR solving?

Short description of the changes

@mwear mwear added breaking size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 8, 2020
@codecov
Copy link

codecov bot commented Oct 8, 2020

Codecov Report

Merging #1581 into master will decrease coverage by 0.38%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1581      +/-   ##
==========================================
- Coverage   93.03%   92.64%   -0.39%     
==========================================
  Files         161      157       -4     
  Lines        4938     4325     -613     
  Branches      995      833     -162     
==========================================
- Hits         4594     4007     -587     
+ Misses        344      318      -26     
Impacted Files Coverage Δ
...ource-detector-aws/src/detectors/AwsEc2Detector.ts 97.87% <ø> (ø)
packages/opentelemetry-resources/src/constants.ts 100.00% <ø> (ø)
packages/opentelemetry-plugin-grpc/src/utils.ts
packages/opentelemetry-plugin-http/src/utils.ts
packages/opentelemetry-plugin-http/src/http.ts
packages/opentelemetry-plugin-grpc/src/grpc.ts
...emetry-core/src/platform/node/RandomIdGenerator.ts 93.75% <0.00%> (+6.25%) ⬆️

@dyladan dyladan merged commit 83e6af0 into open-telemetry:master Oct 9, 2020
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
…-detector-alibaba-cloud (open-telemetry#1581)

* chore: upgrade [email protected] and re-enable test in node@18 for resource-detector-alibaba-cloud

* chore: remove --ignore @opentelemetry/resource-detector-alibaba-cloud in tav pipeline

---------

Co-authored-by: Haddas Bronfman <[email protected]>
Co-authored-by: Amir Blum <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove duplicate hostname resource attribute
4 participants