Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ensure onStart is called with a writeable span #1621

Merged

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Oct 23, 2020

Fixes #1620

Also adds tests to guarantee onStart and onEnd are called synchronously when spans are started and ended as required by specification.

@dyladan
Copy link
Member Author

dyladan commented Oct 23, 2020

@arminru

@codecov
Copy link

codecov bot commented Oct 23, 2020

Codecov Report

Merging #1621 into master will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1621   +/-   ##
=======================================
  Coverage   91.19%   91.19%           
=======================================
  Files         164      164           
  Lines        5033     5033           
  Branches     1026     1026           
=======================================
  Hits         4590     4590           
  Misses        443      443           
Impacted Files Coverage Δ
...es/opentelemetry-tracing/src/MultiSpanProcessor.ts 100.00% <100.00%> (ø)
...ges/opentelemetry-tracing/src/NoopSpanProcessor.ts 42.85% <100.00%> (ø)
...telemetry-tracing/src/export/BatchSpanProcessor.ts 91.93% <100.00%> (ø)
...elemetry-tracing/src/export/SimpleSpanProcessor.ts 83.33% <100.00%> (ø)

@dyladan dyladan merged commit f8988b5 into open-telemetry:master Oct 26, 2020
@dyladan dyladan deleted the read-write-span-onstart branch October 26, 2020 15:30
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spec: SpanProcessor.onStart MUST receive a mutable "read/write" span
4 participants