Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change SpanOptions startTime to TimeInput #1815

Merged
merged 2 commits into from
Jan 13, 2021

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Jan 13, 2021

Fixes #1793

SDK already accepted api.TimeInput so only the API needs to be changed.

@codecov
Copy link

codecov bot commented Jan 13, 2021

Codecov Report

Merging #1815 (07e3a96) into master (fadebf3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1815   +/-   ##
=======================================
  Coverage   92.49%   92.49%           
=======================================
  Files         173      173           
  Lines        6038     6038           
  Branches     1284     1284           
=======================================
  Hits         5585     5585           
  Misses        453      453           

@dyladan dyladan merged commit 4d2ee3b into open-telemetry:master Jan 13, 2021
@dyladan dyladan deleted the api-time-input branch January 13, 2021 22:38
dyladan added a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
dyladan added a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[API] SpanOptions #startTime is of type TimeInput
5 participants