Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fixing status code aligning it with proto #1860

Merged
merged 2 commits into from
Jan 24, 2021

Conversation

obecny
Copy link
Member

@obecny obecny commented Jan 21, 2021

Which problem is this PR solving?

Short description of the changes

Aligning api StatusCode with proto format to avoid any future bugs and other problems.

Currently span status is
0 - OK
1 - Unset
2 - Error

Proto defines this as
0 - Unset
1 - OK
2 - Error

This PR changes Status as in proto

@codecov
Copy link

codecov bot commented Jan 21, 2021

Codecov Report

Merging #1860 (1ba5ad9) into master (960b868) will increase coverage by 0.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1860      +/-   ##
==========================================
+ Coverage   92.39%   92.52%   +0.12%     
==========================================
  Files         170      172       +2     
  Lines        5733     5846     +113     
  Branches     1235     1254      +19     
==========================================
+ Hits         5297     5409     +112     
- Misses        436      437       +1     
Impacted Files Coverage Δ
.../opentelemetry-exporter-collector/src/transform.ts 87.85% <ø> (+2.38%) ⬆️
packages/opentelemetry-api/src/trace/status.ts 100.00% <100.00%> (ø)
...ages/opentelemetry-exporter-collector/src/types.ts 100.00% <100.00%> (ø)
...s/opentelemetry-instrumentation-fetch/src/fetch.ts 96.00% <0.00%> (ø)
...-instrumentation-fetch/src/enums/AttributeNames.ts 100.00% <0.00%> (ø)

@naseemkullah naseemkullah merged commit b85acf0 into open-telemetry:master Jan 24, 2021
@obecny obecny deleted the status_code branch February 2, 2021 17:24
dyladan pushed a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
dyladan pushed a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
[email protected] was a bad release that accidentally broken v14 support.
This updates the versions test to skip that release, and also
reduces the number of versions tested from 27 to 8 by selecting
just the current latest minor releases.

Also, drop the pretest config that (a) was never used
because of the wrong indentation and (b) is no longer
valid since the move to npm workspaces.

Refs: open-telemetry#1860
pichlermarc added a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
The beforeEach() hook was not awaited, so afterEach() could run before
it completed, resulting in a client.disconnect() that rejects, and a
mocha hook that calls done() twice.

Refs: open-telemetry#1860

Co-authored-by: Marc Pichler <[email protected]>
pichlermarc added a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
…telemetry#1861)

This tests just the latest in each minor version.

Refs: open-telemetry#1860

Co-authored-by: Marc Pichler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align status with proto
7 participants