Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix links & headings about built-in samplers #2011

Merged
merged 3 commits into from
Mar 13, 2021

Conversation

pokutuna
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

  • Make them links to existing headings.
  • Change the heading text to add Sampler like about Propagator section.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 11, 2021

CLA Signed

The committers are authorized under a signed CLA.

@codecov
Copy link

codecov bot commented Mar 11, 2021

Codecov Report

Merging #2011 (fd6b86c) into main (0c7fef7) will increase coverage by 3.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2011      +/-   ##
==========================================
+ Coverage   92.97%   96.04%   +3.06%     
==========================================
  Files         152       12     -140     
  Lines        5925      632    -5293     
  Branches     1245      126    -1119     
==========================================
- Hits         5509      607    -4902     
+ Misses        416       25     -391     
Impacted Files Coverage Δ
...ckages/opentelemetry-exporter-zipkin/src/zipkin.ts 81.63% <0.00%> (-18.37%) ⬇️
...strumentation/src/platform/node/instrumentation.ts
packages/opentelemetry-propagator-b3/src/common.ts
...ntelemetry-propagator-b3/src/B3SinglePropagator.ts
...telemetry-core/src/common/logging-error-handler.ts
packages/opentelemetry-sdk-node/src/sdk.ts
...ackages/opentelemetry-metrics/src/CounterMetric.ts
...s/opentelemetry-plugin-grpc-js/src/client/index.ts
packages/opentelemetry-plugin-grpc/src/utils.ts
...es/opentelemetry-propagator-b3/src/B3Propagator.ts
... and 131 more

@dyladan dyladan added the document Documentation-related label Mar 11, 2021
@vmarchaud vmarchaud changed the title docs: fix links & headings about bult-in samplers docs: fix links & headings about built-in samplers Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document Documentation-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants