Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exception.type should always be a string #2086

Merged
merged 4 commits into from
Apr 8, 2021

Conversation

YanivD
Copy link
Member

@YanivD YanivD commented Apr 8, 2021

Which problem is this PR solving?

By Semantic Conventions for Exceptions - exception.type should be a string.

Short description of the changes

Cast to string for numeric exception codes.

@codecov
Copy link

codecov bot commented Apr 8, 2021

Codecov Report

Merging #2086 (8fadccc) into main (fec5e31) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 8fadccc differs from pull request most recent head bf267ad. Consider uploading reports for the commit bf267ad to get more accurate results

@@            Coverage Diff             @@
##             main    #2086      +/-   ##
==========================================
- Coverage   93.05%   93.03%   -0.02%     
==========================================
  Files         154      154              
  Lines        5976     5976              
  Branches     1246     1246              
==========================================
- Hits         5561     5560       -1     
- Misses        415      416       +1     
Impacted Files Coverage Δ
packages/opentelemetry-tracing/src/Span.ts 98.05% <100.00%> (ø)
...emetry-core/src/platform/node/RandomIdGenerator.ts 87.50% <0.00%> (-6.25%) ⬇️

@vmarchaud
Copy link
Member

Could you add a quick test that verify that the result is always a string ?

Copy link
Member

@vmarchaud vmarchaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding the test !

@dyladan dyladan added the bug Something isn't working label Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants