Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: renaming jaeger http trace propagator to jaeger propagator #2148

Merged
merged 8 commits into from
May 4, 2021

Conversation

obecny
Copy link
Member

@obecny obecny commented Apr 22, 2021

Fixes #2136

@codecov
Copy link

codecov bot commented Apr 22, 2021

Codecov Report

Merging #2148 (b07bab1) into main (a9d300d) will not change coverage.
The diff coverage is 100.00%.

❗ Current head b07bab1 differs from pull request most recent head 79234f7. Consider uploading reports for the commit 79234f7 to get more accurate results

@@           Coverage Diff           @@
##             main    #2148   +/-   ##
=======================================
  Coverage   92.82%   92.82%           
=======================================
  Files         140      140           
  Lines        5002     5002           
  Branches     1030     1030           
=======================================
  Hits         4643     4643           
  Misses        359      359           
Impacted Files Coverage Δ
...kages/opentelemetry-node/src/NodeTracerProvider.ts 100.00% <100.00%> (ø)
...elemetry-propagator-jaeger/src/JaegerPropagator.ts 100.00% <100.00%> (ø)

Copy link
Member

@Flarna Flarna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@obecny obecny requested a review from Flarna April 28, 2021 20:31
Copy link
Member

@dyladan dyladan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge when the conflicts are resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider renaming JaegerHttpTracePropagator to JaegerPropagator
5 participants