Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removing usage of timed event from api #2183

Merged
merged 7 commits into from
May 11, 2021
Merged

Conversation

obecny
Copy link
Member

@obecny obecny commented May 4, 2021

Which problem is this PR solving?

  • Removing dependency on TimedEvent from api

Short description of the changes

@codecov
Copy link

codecov bot commented May 4, 2021

Codecov Report

Merging #2183 (6a9a3a9) into main (5f7ec00) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2183      +/-   ##
==========================================
+ Coverage   92.83%   92.85%   +0.01%     
==========================================
  Files         139      139              
  Lines        5024     5024              
  Branches     1035     1035              
==========================================
+ Hits         4664     4665       +1     
+ Misses        360      359       -1     
Impacted Files Coverage Δ
.../opentelemetry-exporter-collector/src/transform.ts 88.69% <ø> (ø)
...ges/opentelemetry-exporter-zipkin/src/transform.ts 100.00% <100.00%> (ø)
packages/opentelemetry-tracing/src/Span.ts 98.07% <100.00%> (ø)
...emetry-core/src/platform/node/RandomIdGenerator.ts 93.75% <0.00%> (+6.25%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider hiding/moving Event/TimedEvent
4 participants