feat(sdk-metrics-base): remove per-meter config on MeterProvider.getMeter #2563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2563 +/- ##
=======================================
Coverage 93.07% 93.07%
=======================================
Files 140 140
Lines 5169 5169
Branches 1101 1101
=======================================
Hits 4811 4811
Misses 358 358 |
…Meter` Makes it compliant with api definition.
legendecas
force-pushed
the
metrics-ff/config-propagation
branch
from
c88fe91
to
53bea7e
Compare
dyladan
approved these changes
Oct 26, 2021
vmarchaud
approved these changes
Oct 26, 2021
1 task
1 task
|
Can you please fix the conflicts so I can merge this? |
# Conflicts: # experimental/packages/opentelemetry-sdk-metrics-base/src/MeterProvider.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
API doesn't allow to pass a meter config to
getMeter.Related: #2546
Related: #2547
Short description of the changes
Removes per-meter config on
MeterProvider.getMeter.Type of change
Checklist: