Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adding selenium tests with browserstack #2570

Merged
merged 3 commits into from
Nov 8, 2021

Conversation

obecny
Copy link
Member

@obecny obecny commented Oct 28, 2021

Which problem is this PR solving?

Adding selenium test with browserstack

Short description of the changes

This is first part to be able to run tests either locally with local browser or using local server and browser stack (this requires account on browserstack)

Next step will be to add github action to run tests automatically with browserstack. Can be done once this is merged and we decide how and when we want to run it

@obecny obecny requested a review from a team as a code owner October 28, 2021 13:19
@codecov
Copy link

codecov bot commented Oct 28, 2021

Codecov Report

Merging #2570 (67c0685) into main (8227258) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2570   +/-   ##
=======================================
  Coverage   93.00%   93.00%           
=======================================
  Files         138      138           
  Lines        5092     5092           
  Branches     1095     1095           
=======================================
  Hits         4736     4736           
  Misses        356      356           

@obecny obecny force-pushed the selenium branch 5 times, most recently from 3b31f9d to 422253a Compare October 28, 2021 13:55
@dyladan
Copy link
Member

dyladan commented Oct 29, 2021

Looks like selenium isn't compatible with node 8. We can either skip it in the bootstrap on node 8 or we can drop support for node 8 unless you have another option.

Node 16 is a little different. Looks like a dependency mismatch with the hoisting due to the new peer dependency handling in node 16

@obecny
Copy link
Member Author

obecny commented Oct 29, 2021

Looks like selenium isn't compatible with node 8. We can either skip it in the bootstrap on node 8 or we can drop support for node 8 unless you have another option.

Node 16 is a little different. Looks like a dependency mismatch with the hoisting due to the new peer dependency handling in node 16

I wasn't sure how to do it (skip it in the bootstrap on node 8) , any example ?

@dyladan
Copy link
Member

dyladan commented Oct 29, 2021

Looks like selenium isn't compatible with node 8. We can either skip it in the bootstrap on node 8 or we can drop support for node 8 unless you have another option.
Node 16 is a little different. Looks like a dependency mismatch with the hoisting due to the new peer dependency handling in node 16

I wasn't sure how to do it (skip it in the bootstrap on node 8) , any example ?

I think you should be able to just add --ignore @opentelemetry/selenium-tests to the bootstrap commands. Doing it only on node 8 should just be an if directive in the github action like this https://github.com/open-telemetry/opentelemetry-js/blob/main/.github/workflows/unit-test.yml#L48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants