Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: start a style guide #2683

Merged
merged 5 commits into from
Dec 23, 2021
Merged

chore: start a style guide #2683

merged 5 commits into from
Dec 23, 2021

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Dec 22, 2021

This should be considered a living document. Please make suggestions for additional rules if you feel there is something important that has been missed.

@dyladan dyladan requested a review from a team as a code owner December 22, 2021 15:38
@codecov
Copy link

codecov bot commented Dec 22, 2021

Codecov Report

Merging #2683 (a29c633) into main (d9e12e2) will not change coverage.
The diff coverage is n/a.

❗ Current head a29c633 differs from pull request most recent head e69256c. Consider uploading reports for the commit e69256c to get more accurate results

@@           Coverage Diff           @@
##             main    #2683   +/-   ##
=======================================
  Coverage   92.52%   92.52%           
=======================================
  Files         144      144           
  Lines        5177     5177           
  Branches     1102     1102           
=======================================
  Hits         4790     4790           
  Misses        387      387           

style.md Outdated Show resolved Hide resolved
Co-authored-by: legendecas <[email protected]>
Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@vmarchaud vmarchaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i believe we should advise against using null and prefer using undefined (even though we treat them as the same) too

@dyladan
Copy link
Member Author

dyladan commented Dec 23, 2021

i believe we should advise against using null and prefer using undefined (even though we treat them as the same) too

e69256c (#2683)

@dyladan dyladan merged commit 50252a9 into open-telemetry:main Dec 23, 2021
@dyladan dyladan deleted the style-guide branch December 23, 2021 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants