Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(propagator-jaeger): 0-pad span-id to match 16-symbol validation #2694

Merged
merged 3 commits into from
Jan 5, 2022

Conversation

nikolaylagutko
Copy link
Contributor

Which problem is this PR solving?

0-pad Span ID received from Carrier to 16-characters format according to Jaeger Propagation Format

Short description of the changes

Type of change

Please delete options that are not relevant.

  • [*] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [*] Can be verified by using Jaeger Python Client to generate parent spans. Sometimes Python library generates 15-character-length Span ID so OpenTelemetry doesn't create reference to Parent Span

Checklist:

  • [*] Followed the style guidelines of this project
  • [*] Unit tests have been added
  • [-] Documentation has been updated

@nikolaylagutko nikolaylagutko requested a review from a team as a code owner December 29, 2021 18:30
@linux-foundation-easycla
Copy link

CLA Not Signed

@codecov
Copy link

codecov bot commented Dec 29, 2021

Codecov Report

Merging #2694 (9aa1f1e) into main (fb2031b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2694   +/-   ##
=======================================
  Coverage   92.57%   92.57%           
=======================================
  Files         151      151           
  Lines        5276     5277    +1     
  Branches     1116     1116           
=======================================
+ Hits         4884     4885    +1     
  Misses        392      392           
Impacted Files Coverage Δ
...elemetry-propagator-jaeger/src/JaegerPropagator.ts 100.00% <100.00%> (ø)

@linux-foundation-easycla

This comment has been minimized.

@linux-foundation-easycla

This comment has been minimized.

@dyladan dyladan merged commit 5f3cbc2 into open-telemetry:main Jan 5, 2022
rauno56 pushed a commit to rauno56/opentelemetry-js that referenced this pull request Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants