Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add Chengzhong Wu as maintainer #2702

Merged
merged 3 commits into from
Jan 5, 2022

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Jan 4, 2022

Propose Chengzhong Wu as maintainer of OpenTelemetry Javascript in recognition of his work on the project. Chengzhong has show good judgement in all areas of the project, and has been especially helpful in development the API and the metrics SDK.

@dyladan dyladan requested a review from a team as a code owner January 4, 2022 21:15
@codecov
Copy link

codecov bot commented Jan 4, 2022

Codecov Report

Merging #2702 (ff2d5b4) into main (dce6eb7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2702   +/-   ##
=======================================
  Coverage   92.57%   92.57%           
=======================================
  Files         151      151           
  Lines        5276     5276           
  Branches     1116     1116           
=======================================
  Hits         4884     4884           
  Misses        392      392           

Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thanks!

README.md Show resolved Hide resolved
@rauno56
Copy link
Member

rauno56 commented Jan 5, 2022

Also, remove @legendecas(and me. Amir seems to already be missing anyway) from the approvers list?

@vmarchaud
Copy link
Member

Also, remove @legendecas(and me. Amir seems to already be missing anyway) from the approvers list?

I think daniel planned to do it in a different PR

@vmarchaud vmarchaud merged commit fb2031b into open-telemetry:main Jan 5, 2022
@dyladan dyladan deleted the legendecas-maintainer branch January 5, 2022 13:43
@dyladan
Copy link
Member Author

dyladan commented Jan 5, 2022

No I did it in this one

rauno56 pushed a commit to rauno56/opentelemetry-js that referenced this pull request Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants