chore: require a changelog entry to merge PR #2847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2847 +/- ##
=======================================
Coverage 93.42% 93.42%
=======================================
Files 162 162
Lines 5564 5564
Branches 1175 1175
=======================================
Hits 5198 5198
Misses 366 366 |
|
Do we have a guideline on which condition we don't need a changelog? |
Updated the contributing.md |
MSNev
approved these changes
Mar 22, 2022
rauno56
approved these changes
Mar 30, 2022
rauno56
reviewed
Mar 30, 2022
| # least one CHANGELOG file. If a CHANGELOG entry is not required, add the "Skip | ||
| # Changelog" label to disable this action. | ||
|
|
||
| name: changelog |
There was a problem hiding this comment.
Tiniest of the tiny nits: capitalize this since all others start with a capital letter.
vmarchaud
approved these changes
Mar 31, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was taken directly from the collector so I expect it should work for us just fine.