Feat support otel sdk disabled env #3485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3485 +/- ##
==========================================
+ Coverage 93.74% 93.77% +0.02%
==========================================
Files 249 249
Lines 7593 7610 +17
Branches 1582 1587 +5
==========================================
+ Hits 7118 7136 +18
+ Misses 475 474 -1
|
blumamir
approved these changes
Dec 13, 2022
|
Might be useful to also document it in the README for the SDK package |
legendecas
reviewed
Dec 15, 2022
comment fix tests for falsy OTEL_SDK_DISABLED values
osherv
approved these changes
Dec 19, 2022
legendecas
reviewed
Dec 20, 2022
legendecas
approved these changes
Dec 20, 2022
blumamir
reviewed
Dec 20, 2022
legendecas
reviewed
Dec 28, 2022
legendecas
approved these changes
Dec 28, 2022
|
Looks like there is a lint error. Would you mind fixing it? Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Support for the
OTEL_SDK_DISABLEDenv variable.Short description of the changes
In the case of a truthy value, the SDK functions(
start,detectResources) that might create side effects are set to be no-op.Parsing of boolean env variables.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
sdk.startshould be a no-op. Should not register a trace/meter provider.sdk.detectResourcesshould be a no-op. Should not detect resources.Checklist: