fix(sdk-metrics): merge uncollected delta accumulations #3667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legendecas
force-pushed
the
metrics/cumulative-batch
branch
from
20e8415
to
e805525
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3667 +/- ##
==========================================
- Coverage 93.93% 93.71% -0.22%
==========================================
Files 256 277 +21
Lines 7152 8451 +1299
Branches 1472 1755 +283
==========================================
+ Hits 6718 7920 +1202
- Misses 434 531 +97
|
legendecas
force-pushed
the
metrics/cumulative-batch
branch
from
e805525
to
41d3d1e
Compare
pichlermarc
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Fixes #3664
Short description of the changes
When two metric readers are registered and an async instrument is created, two async metric storages are created for each metric reader.
When one metric reader initiates collection on the async instrument, both async metric storages recorded the observed values. However, only one async metric storage that corresponds to the initiating metric reader is collected.
Next, when another metric reader initiates collection, both async metric storages recorded the observed values. But the async metric storage that corresponds to the reader has uncollected active delta accumulations. Those delta accumulations should be merged.
Type of change
How Has This Been Tested?
DeltaMetricProcessor.batchCumulateshould merge uncollected active delta.packages/sdk-metrics/test/regression/two-metric-readers-async-instrument.test.ts.Checklist:
Documentation has been updated