fix(sdk-metrics): preserve startTime for cumulative ExponentialHistograms #3934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aabmass
force-pushed
the
starttimebugfix
branch
2 times, most recently
from
246c4ba
to
2852cbf
Compare
aabmass
commented
Jun 21, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3934 +/- ##
==========================================
+ Coverage 92.90% 92.97% +0.06%
==========================================
Files 297 297
Lines 8838 8839 +1
Branches 1815 1815
==========================================
+ Hits 8211 8218 +7
+ Misses 627 621 -6
|
pichlermarc
approved these changes
Jun 22, 2023
There was a problem hiding this comment.
Looks good, thanks for fixing this 🙂
cc @mwear would you mind taking a look? 🙂
pichlermarc
added
release:next-minor-version
bug
This was referenced Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Fixes #3931
Short description of the changes
We were throwing away previous value's
startTime. This updates to keep the older (previous)startTimewhen merging. See similar logic for Histograms: https://github.com/aabmass/opentelemetry-js/blob/b4fde50bb8e9848e70b1c9c2db5d6909741b422c/packages/sdk-metrics/src/aggregator/Histogram.ts#L154Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Added a new integration/regression test. Updated the unit tests.
Checklist: