test: transpile zone.js products in test #4423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legendecas
force-pushed
the
test/zone.js
branch
from
892f8b9
to
ea1aaa5
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4423 +/- ##
==========================================
- Coverage 92.19% 91.94% -0.26%
==========================================
Files 336 278 -58
Lines 9512 6802 -2710
Branches 2016 1390 -626
==========================================
- Hits 8770 6254 -2516
+ Misses 742 548 -194
|
pichlermarc
reviewed
Jan 17, 2024
| @@ -49,6 +49,7 @@ | |||
| }, | |||
| "devDependencies": { | |||
| "@babel/core": "7.23.6", | |||
| "@babel/preset-env": "7.22.20", | |||
There was a problem hiding this comment.
Hmm, do we need this here? 🤔
The gRPC exporter only supports Node.js so we never use it right? 🤔 We may also be able to drop @babel/core.
There was a problem hiding this comment.
Well, yeah, thank you for spotting this. Unnecessary test dependencies removed.
legendecas
force-pushed
the
test/zone.js
branch
from
ea1aaa5
to
541b5e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Test with zone.js' default export entry rather than specifying
'zone.js/dist/index'Short description of the changes
Zone.js' default export entry that is picked by the bundler contains new syntax that needs to be transpiled.
Type of change
Checklist: