deps(opentelemetry-instrumentation): Bump shimmer types to 1.2.0 #4865
Conversation
lforst
force-pushed
the
lforst-bump-shimmer
branch
from
1e98c70
to
3b84e3b
Compare
| @@ -38727,7 +38727,7 @@ | |||
| "version": "file:experimental/packages/opentelemetry-instrumentation-grpc", | |||
| "requires": { | |||
| "@bufbuild/buf": "1.21.0-1", | |||
| "@grpc/grpc-js": "^1.10.10", | |||
There was a problem hiding this comment.
Ugh... so that arguable staleness came from this renovatebot change: #4822
which, IIUC, is normally fixed up by a regular "lock file maintenance" PR.
This one: #4834
That one does indeed make this same kind of cleanup in the lock file. However, there is another issue (in an unrelated package) that is blocking that #4834.
I've been leaning on @pichlermarc's confidence in the "lock file maintenance" thing being sufficient. Marc's on vacation for a while, so I'm not sure the best course of action.
I assume you got these package-lock changes from just running npm update @types/shimmer or npm install @types/shimmer?
There was a problem hiding this comment.
Correct. This is just from a normal npm i. If this is fixed in the main branch I can just rebase.
There was a problem hiding this comment.
I don't think it is fixed in main yet. See the "discussion" at #4834.
I think taking the package-lock changes you have in this PR would likely be fine, but all-things-being-equal I'd tend to wait for Marc's opinion. I'll discuss with some others tomorrow.
There was a problem hiding this comment.
Sounds perfectly reasonable to me! :) Thanks for taking the time!
There was a problem hiding this comment.
Discussed in the OTel JS SIG today (https://docs.google.com/document/d/1tCyoQK49WVcE-x8oryZOTTToFm7sIeUhxFPm9g-qL1k/edit#heading=h.7awcc4kiwbis). Discussion veered widely into TypeScript versions used in OTel JS, but for this issue the SIG notes have a succinct "doit". :)
Which problem is this PR solving?
Bumps the shimmer package to a version that doesn't include an invasive type that breaks certain setups.
See PR for more details: DefinitelyTyped/DefinitelyTyped#69966
Fixes getsentry/sentry-javascript#12682
This PR supersedes #4835
Short description of the changes
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
I don't think tests are necessary here. Feel free to let me know though!
Checklist:
Unit tests have been addedDocumentation has been updated