Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-dns): remove from default plugin list #613

Conversation

OlivierAlbertini
Copy link
Member

Which problem is this PR solving?

Short description of the changes

  • remove dns plugin from the default list
  • add doc for Zipkin until with find a solution that let's us ignore http call without specifying in plugin option

@codecov-io
Copy link

codecov-io commented Dec 11, 2019

Codecov Report

Merging #613 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #613      +/-   ##
==========================================
- Coverage   90.44%   90.39%   -0.05%     
==========================================
  Files         181      176       -5     
  Lines        9164     9062     -102     
  Branches      814      792      -22     
==========================================
- Hits         8288     8192      -96     
+ Misses        876      870       -6
Impacted Files Coverage Δ
packages/opentelemetry-node/src/config.ts 100% <ø> (ø) ⬆️
...ges/opentelemetry-plugin-https/test/utils/utils.ts 33.33% <0%> (-26.67%) ⬇️
.../opentelemetry-plugin-redis/test/assertionUtils.ts 95.83% <0%> (-4.17%) ⬇️
...res/opentelemetry-plugin-pg/test/assertionUtils.ts 96.29% <0%> (-3.71%) ⬇️
...opentelemetry-base/test/resources/resource.test.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-plugin-https/src/utils.ts 100% <0%> (ø) ⬆️
...es/opentelemetry-exporter-collector/test/helper.ts 100% <0%> (ø) ⬆️
...es/opentelemetry-plugin-document-load/src/utils.ts
packages/opentelemetry-metrics/src/types.ts
...y-plugin-document-load/src/enums/AttributeNames.ts
... and 4 more

@mayurkale22 mayurkale22 added Agreed bug Something isn't working Merge:LGTM This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.) labels Dec 11, 2019
@mayurkale22
Copy link
Member

It would be nice to have note next to DNS plugin here and here.

@mayurkale22
Copy link
Member

It would be nice to have note next to DNS plugin here and here.

Let's handle this in separate PR, don't want to block release due to this.

@mayurkale22 mayurkale22 merged commit 9a91434 into open-telemetry:master Dec 12, 2019
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Merge:LGTM This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Dns plugin from the config
5 participants