Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: port mongodb-core plugin to mongodb #622 #652

Merged

Conversation

vmarchaud
Copy link
Member

Actually most of the code was working with the higher level mongodb driver so i didn't change much code.
I've tested on mongodb version 2, 3.3 and 3.4 and it's working well.

@vmarchaud vmarchaud added the enhancement New feature or request label Dec 29, 2019
@vmarchaud vmarchaud added this to the Alpha v0.4 milestone Dec 29, 2019
@vmarchaud vmarchaud self-assigned this Dec 29, 2019
@codecov-io
Copy link

codecov-io commented Dec 29, 2019

Codecov Report

Merging #652 into master will increase coverage by 35.35%.
The diff coverage is 81.81%.

@@             Coverage Diff             @@
##           master     #652       +/-   ##
===========================================
+ Coverage    56.2%   91.55%   +35.35%     
===========================================
  Files          69      215      +146     
  Lines        1943    10192     +8249     
  Branches      236      912      +676     
===========================================
+ Hits         1092     9331     +8239     
- Misses        851      861       +10
Impacted Files Coverage Δ
packages/opentelemetry-plugin-mongodb/src/types.ts 100% <ø> (ø)
packages/opentelemetry-node/src/config.ts 100% <ø> (ø)
.../opentelemetry-plugin-mongodb/test/mongodb.test.ts 92.64% <ø> (ø)
...ckages/opentelemetry-plugin-mongodb/src/mongodb.ts 93.33% <81.81%> (ø)
...telemetry-core/src/context/propagation/B3Format.ts 94.59% <0%> (-2.55%) ⬇️
...core/src/context/propagation/BinaryTraceContext.ts 96.22% <0%> (-1.82%) ⬇️
...opentelemetry-core/src/trace/globaltracer-utils.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-core/src/utils/url.ts 100% <0%> (ø) ⬆️
.../opentelemetry-core/src/trace/spancontext-utils.ts 100% <0%> (ø) ⬆️
...es/opentelemetry-exporter-collector/test/helper.ts 100% <0%> (ø) ⬆️
... and 167 more

@dyladan
Copy link
Member

dyladan commented Jan 1, 2020

@vmarchaud please try not to force push on open PRs if possible. It makes it hard to track requested changes because the github UI doesn't associate the conversations with the correct line numbers anymore.

Copy link
Member

@OlivierAlbertini OlivierAlbertini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mayurkale22
Copy link
Member

I think we should put the deprecated message on existing mongodb-core npm module.

Something like this:
Screen Shot 2020-01-02 at 2 37 55 PM

WDYT?

@vmarchaud
Copy link
Member Author

Tests are failling because https://david-dm.org which is used for badges is apparently down, i believe it's safe to merge as-is and maybe fix that in another PR

@mayurkale22 mayurkale22 merged commit 53c40c1 into open-telemetry:master Jan 3, 2020
@vmarchaud vmarchaud deleted the migrate-mongodb-core-plugin branch January 4, 2020 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants