Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(opentracing-shim): update opentracing shim example #990

Merged
merged 3 commits into from
Apr 29, 2020
Merged

fix(opentracing-shim): update opentracing shim example #990

merged 3 commits into from
Apr 29, 2020

Conversation

sleighzy
Copy link
Contributor

Which problem is this PR solving?

A previous update to the opentracing-shim example had modified to this to incorrectly use a setter method to set the global tracer. A similar method exists on the OpenTelemetry API but not the OpenTracing API. This was causing JavaScript errors when attempting to run the example.

Short description of the changes

Update to call the correct method on the OpenTracing API to initialise the global tracer.

Fixes #988

Update initialisation of OpenTracing GlobalTracer in opentracing shim example. A previous update had modified to this to incorrectly use
a set method that does not exist on that API.
@codecov-io
Copy link

codecov-io commented Apr 28, 2020

Codecov Report

Merging #990 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #990   +/-   ##
=======================================
  Coverage   94.95%   94.95%           
=======================================
  Files         210      210           
  Lines        8571     8571           
  Branches      772      772           
=======================================
  Hits         8139     8139           
  Misses        432      432           

@mayurkale22 mayurkale22 added the document Documentation-related label Apr 28, 2020
@dyladan dyladan merged commit 5d2aef3 into open-telemetry:master Apr 29, 2020
@sleighzy sleighzy deleted the fix-opentelemetry-js-shim-example branch April 29, 2020 21:26
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document Documentation-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid method used for initialising GlobalTracer in opentracing-shim example
5 participants