Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add verification when request body is falsy #1702

Merged
merged 3 commits into from
Jul 2, 2024
Merged

fix: add verification when request body is falsy #1702

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f25b9a4
fix: add verification when request body is falsy
eduardohilariodev Jun 19, 2024
2d6e957
Update index.js
eduardohilariodev Jun 19, 2024
429b2b0
style: Update conditional check for FormData instance
eduardohilariodev Jun 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/openapi-fetch/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ export default function createClient(clientOptions) {
requestInit.body = bodySerializer(requestInit.body);
}
// remove `Content-Type` if serialized body is FormData; browser will correctly set Content-Type & boundary expression
if (requestInit.body instanceof FormData) {
if (requestInit.body && requestInit.body instanceof FormData) {
Copy link

@imranbarbhuiya imranbarbhuiya Jun 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (requestInit.body && requestInit.body instanceof FormData) {
if (!requestInit.body || requestInit.body instanceof FormData) {

altho out of scope for this pr but we should delete the content type when body is empty, currently there's no proper way to remove the body and when I don't need to send any body to backend, backend throws content type json was used but no body provided

Edit: ignore this, for some reason github didn't loaded the above conversations which has discussions related to it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I may have approved prematurely because I didn‘t realize at first this was attempting to solve 2 issues with 1 PR. My suggestions should be a ~2-line change in code, and a couple test additions to satisfy both.

requestInit.headers.delete("Content-Type");
}
let request = new CustomRequest(createFinalURL(url, { baseUrl, params, querySerializer }), requestInit);
Expand Down