-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(2/3) Bugfixes #604
(2/3) Bugfixes #604
Conversation
`label.category` is only set for preexisting categories, not for ones created during the current browser session.
With this patch, the frontend also knows about deleted labels, categories, scales and scale values. This makes the behavior of annotations carrying any of that deleted structure much more consistent.
Previously it already showed the editing interface for the scale of the category you got to the dialog with. It wasn't fully in edit mode yet, though, so edits could get lost.
Make every caller pass their preferred type instead of doing a cast.
Co-authored-by: Julian Kniephoff <[email protected]>
Co-authored-by: Julian Kniephoff <[email protected]>
Fix db compatibility issues with Opencast 13
* Minimally improve the formatting * Remove useless settings
Thanks Arnei for having a look into it.
Bug or feature? 🧐 Notes for readers:
This seems plausible for me to some extend. Regular MCA (without annotation template) should behave the same.
Which branch did you review? The annotation list should be shown in 3/3 branch; commit d089bea should have fix that (show the annotation list in annotation template view). ![]()
This should be possible in the branch mentioned above:
There are also some "hidden" ways to show the areas whenever it is useful, e.g.
This should be a known bug originating from the current master version which introduced sharing categories with series leading to this duplication. As this bug should already exist in the master version and was not introduced by the merge, this should not be handled as a blocker for the merge but should be looked into later on. Some details on that matter from internal discussions which might be outdated:
Reproduction hints:
The error (duplicates) occurs e.g. (not only) as soon as another video of the series gets the series category (as annotation). Possible Request triggering the incident:
Note: |
Oh, so the save button for the whole template does do time stamp validation, did not know that. Arguably that is not very helpful, as it asks you to ignore the prominent "annotation end" save button. Which you cannot do if you also want to edit "annotation start". I'd be in favor of your suggestion, or just doing away with the "annotation end" save and cancel buttons
Reviewed this branch (2/3), thanks for telling me about the fix in 3/3.
Agreed, not a blocker then. Should have checked if that issues already existed, my bad. |
+1
No worries, I'd suggest to check the described behavior in the master version again to make sure it's the same bug. |
Update `h2`
Revert "Update `h2`"
* Minimally improve the formatting * Remove useless settings
That `when` was in the wrong place.
This makes the tests work with newer Java versions (tested with 20) and also fixes a warning about invalid POMs during the Maven build.
When building with Maven's `-T` option the build was warning about two plugins that might not be thread safe. This patch updates one and removes the other. Regarding static weaving: It might be interesting to look at at some point, but it's "only" for performance and Opencast removed this as well: opencast/opencast#3031.
Also some minor nitpicks and fixing of lints.
This branch builds upon the merged version from PR #603
The Bern (B, current master) and Münster (MS, questionnaire branch) versions had serveral bugs which were fixed after the merge, e.g.
The export function was broken due to introduction of MCA (MS)
A scale could not be edited (B)
![image](https://user-images.githubusercontent.com/81566097/229468180-a19ac4f3-c297-4c66-8639-dad3f84c36b0.png)
A shared category ("with all users") could not be edited from the same user (B)
![image](https://user-images.githubusercontent.com/81566097/229468428-6ac4417d-6c85-4d17-a43b-1e05ecf15b49.png)
An assigned scale could not be used (B)
![image](https://user-images.githubusercontent.com/81566097/229468088-304409bd-60dd-4809-b3db-6cdc64fa0282.png)
The new edit menu was out of bounds / cut off (B)
![image](https://user-images.githubusercontent.com/81566097/229468028-2fb8e082-cec7-4a0e-82c8-1971aacdf432.png)
see commits for further bug fixes