Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump github.com/opencontainers/runtime-spec from 1.1.1-0.20230823135140-4fec88fd00a4 to 1.2.0 #4203

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 14, 2024

Bumps github.com/opencontainers/runtime-spec from 1.1.1-0.20230823135140-4fec88fd00a4 to 1.2.0.

Release notes

Sourced from github.com/opencontainers/runtime-spec's releases.

v1.2.0

Votes: #1242

Additions

  • config: add idmap and ridmap mount options (#1222)
  • config.md: allow empty mappings for [r]idmap (#1224)
  • features-linux: Expose idmap information (#1219)
  • mount: Allow relative mount destinations on Linux (#1225)
  • features: add potentiallyUnsafeConfigAnnotations (#1205)
  • config: add support for org.opencontainers.image annotations #1197

Minor fixes:

  • config: improve bind mount and propagation doc (#1228)

Documentation, CI & Governance:

  • fix link to hooks in features (#1226)
  • specs-go: add missing deprecation comment for Hooks.Prestart (#1232)
  • specs-go: mark LinuxMemory.Kernel as deprecated ()#1233)
Changelog

Sourced from github.com/opencontainers/runtime-spec's changelog.

OpenContainers Specifications

Changes with v1.2.0:

Additions:

  • config: add idmap and ridmap mount options (#1222)
  • config.md: allow empty mappings for [r]idmap (#1224)
  • features-linux: Expose idmap information (#1219)
  • mount: Allow relative mount destinations on Linux (#1225)
  • features: add potentiallyUnsafeConfigAnnotations (#1205)
  • config: add support for org.opencontainers.image annotations #1197

Minor fixes:

  • config: improve bind mount and propagation doc (#1228)

Documentation, CI & Governance:

  • fix link to hooks in features (#1226)
  • specs-go: add missing deprecation comment for Hooks.Prestart (#1232)
  • specs-go: mark LinuxMemory.Kernel as deprecated ()#1233)

Changes with v1.1.0:

Breaking changes (but rather conforms to the existing runc implementation):

  • config: change prestart hook spec to match reality (#1169)

Deprecations:

  • config-linux: mark memory.kernel[TCP] as NOT RECOMMENDED (#1093)

Additions:

  • cgroup: add cgroup v2 support (#1040)
  • seccomp: allow to override errno return code (#1041)
  • seccomp: Add support for SCMP_ACT_KILL_PROCESS (#1044)
  • Update seccomp architectures to support RISCV64 (#1059)
  • Add support for SCMP_ACT_KILL_THREAD (#1064)
  • Add Seccomp Notify support using UNIX sockets and container metadata (#1074)
  • config-linux: Add Intel RDT CMT and MBM Linux support (#1076)
  • seccomp: allow to override default errno return code (#1087)
  • Introduce zos as platform (#1095)
  • config-linux: add idle option for container cgroup (#1136)
  • config-linux: add CFS bandwidth burst (#1120)
  • IDMapping field for mount point (#1143)
  • schema: add cpu idle (#1145)
  • add domainname spec entity (#1156)
  • config-linux: add memory.checkBeforeUpdate (#1158)

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Feb 14, 2024
Copy link
Member

@rata rata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kolyshkin
Copy link
Contributor

This now needs some linter annotations (or, should we drop support for obsoleted features)?

@rata
Copy link
Member

rata commented Feb 14, 2024

@kolyshkin wow, how is the linter catching those? Amazing (even if not very useful for us in this case)

@kolyshkin
Copy link
Contributor

kolyshkin commented Feb 22, 2024

@kolyshkin wow, how is the linter catching those? Amazing (even if not very useful for us in this case)

No magic here. Since they are properly (as per https://zchee.github.io/golang-wiki/Deprecated/) marked as deprecated (see opencontainers/runtime-spec#1232, opencontainers/runtime-spec#1233), and golangci-lint has at least one linter (staticcheck) that has a check (https://staticcheck.dev/docs/checks/#SA1019) that checks for usage of those identifiers that are marked as deprecated.

@AkihiroSuda AkihiroSuda force-pushed the dependabot/go_modules/github.com/opencontainers/runtime-spec-1.2.0 branch from 85df165 to e138695 Compare March 4, 2024 22:42
@AkihiroSuda
Copy link
Member

Fixed lint errors

@AkihiroSuda AkihiroSuda modified the milestones: 1.3.0, 1.2.0 Mar 4, 2024
@AkihiroSuda AkihiroSuda requested review from rata and kolyshkin and removed request for rata March 6, 2024 10:29
docs/spec-conformance.md Outdated Show resolved Hide resolved
Bumps [github.com/opencontainers/runtime-spec](https://github.com/opencontainers/runtime-spec) from 1.1.1-0.20230823135140-4fec88fd00a4 to 1.2.0.
- [Release notes](https://github.com/opencontainers/runtime-spec/releases)
- [Changelog](https://github.com/opencontainers/runtime-spec/blob/main/ChangeLog)
- [Commits](https://github.com/opencontainers/runtime-spec/commits/v1.2.0)

---
updated-dependencies:
- dependency-name: github.com/opencontainers/runtime-spec
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Akihiro Suda <[email protected]>
@AkihiroSuda AkihiroSuda force-pushed the dependabot/go_modules/github.com/opencontainers/runtime-spec-1.2.0 branch from e138695 to 606251a Compare March 7, 2024 05:43
@AkihiroSuda AkihiroSuda requested a review from cyphar March 7, 2024 05:44
Copy link
Member

@cyphar cyphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @dependabot merge

@dependabot dependabot bot merged commit 109a7a0 into main Mar 9, 2024
45 checks passed
@dependabot dependabot bot deleted the dependabot/go_modules/github.com/opencontainers/runtime-spec-1.2.0 branch March 9, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants