SE-3175 Bump codecov to latest version #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openedx-webhooks
added
needs triage
open-source-contribution
|
Thanks for the pull request, @swalladge! I've created OSPR-4904 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
samuelallan72
force-pushed
the
samuel/fix-codecov-version
branch
from
131ebf4
to
e77c592
Compare
Codecov 0.1.x were yanked from rubygems, causing installation of cs_comments_service to fail. The changes here were created by running `bundle update codecov`. Fixes openedx#322
samuelallan72
force-pushed
the
samuel/fix-codecov-version
branch
from
e77c592
to
db4d91e
Compare
|
👍 Thanks for getting this fixed so quickly @swalladge !
|
pomegranited
approved these changes
Aug 19, 2020
samuelallan72
referenced
this pull request
in open-craft/cs_comments_service
Aug 19, 2020
Codecov 0.1.x were yanked from rubygems, causing installation of cs_comments_service to fail. The changes here were created by running `bundle update codecov`. This was ported from the PR against cs_comments_service master: https://github.com/edx/cs_comments_service/pull/323 . Not a direct cherry pick because of conflicts.
This was referenced Aug 19, 2020
|
@ihtram Can you give it a look? |
1 task
|
@swalladge 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
|
I have cherry-picked this to Juniper. |
1 task
akirasankun
referenced
this pull request
in akirasankun/cs_comments_service
Nov 24, 2020
Codecov 0.1.x were yanked from rubygems, causing installation of cs_comments_service to fail. The changes here were created by running `bundle update codecov`. This was ported from the PR against cs_comments_service master: edx#323 . Not a direct cherry pick because of conflicts.
Agrendalath
referenced
this pull request
in open-craft/cs_comments_service
Dec 14, 2020
Codecov 0.1.x were yanked from rubygems, causing installation of cs_comments_service to fail. This was ported from the PR against cs_comments_service master: edx#323 . Not a direct cherry pick because of conflicts.
Agrendalath
referenced
this pull request
in open-craft/cs_comments_service
Dec 28, 2020
Codecov 0.1.x were yanked from rubygems, causing installation of cs_comments_service to fail. The initial approach was porting #5, which was ported from the PR against cs_comments_service master: edx#323. However it's still not working with an older ruby version, so we decided to delete this dependency, as we're not using it anyway. It shouldn't actually be installed, as it's in the test group, but since this is a backport that we'll use only temporarily (before upgrading the instance) it didn't make too much sense to dig into this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Codecov 0.1.x was yanked from rubygems, causing installation of
cs_comments_service to fail. This bumps to the latest codecov version from rubygems.org.
Jira tickets: OSPR-4904
Merge Deadline: ASAP - this is breaking provisioning for all Open edX instances that use cs_comments_service.
Test instructions:
Author notes:
The codecov changelog at this revision does not mention any breaking changes. The minor version bump appears to be related to which api it uses to upload the data to, rather than changing the local api.
Reviewers:
Fixes #322