Library info sidebar UI fixes

[ChrisChV]

Description

UI fixes from comments from AC Testing of Library Info Sidebar:

Supporting information

• Github issue: Library Info Sidebar #1041
• Internal ticket: FAL-3812

Testing instructions

• Open a library in the course authoring MFE
• Check that the Library Info Sidebar is open by default
• Check that you can close the Library Info Sidebar by clicking the Library Info button next to the New button.
• Verify all the changes commented in AC testing

Settings

EDX_PLATFORM_REPOSITORY: https://github.com/open-craft/edx-platform.git
EDX_PLATFORM_VERSION: rpenido/fal-3800-allow-update-fields-without-data

TUTOR_GROVE_ADDITIONAL_DOMAINS:
 - domain: meilisearch.{{ LMS_HOST }}

TUTOR_GROVE_MFE_LMS_COMMON_SETTINGS: MFE_CONFIG["LIBRARY_MODE"] = "mixed"

PLUGINS:
- mfe
- grove
- s3
- meilisearch

Tutor requirements

git+https://github.com/overhangio/tutor.git@nightly
git+https://github.com/overhangio/tutor-mfe@nightly
git+https://gitlab.com/opencraft/dev/tutor-contrib-grove.git@main
git+https://github.com/open-craft/tutor-contrib-meilisearch.git@main
git+https://github.com/hastexo/[email protected]

[openedx-webhooks]

Thanks for the pull request, @ChrisChV!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

• If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
  • This process (including the steps you'll need to take) is documented here.
• If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

• Dependencies

  This PR must be merged before / after / at the same time as ...

• Blockers

  This PR is waiting for OEP-1234 to be accepted.

• Timeline information

  This PR must be merged by XX date because ...

• Partner information

  This is for a course on edx.org.

• Supporting documentation
• Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/2u-tnl. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

• Overview of Review Process for Community Contributions
• Pull Request Status Guide
• Making changes to your pull request

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

• The size and impact of the changes that it introduces
• The need for product review
• Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.03%. Comparing base (3e0f7b5) to head (9b70948).
Report is 2 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1226   +/-   ##
=======================================
  Coverage   93.03%   93.03%           
=======================================
  Files         756      756           
  Lines       13716    13724    +8     
  Branches     2969     2965    -4     
=======================================
+ Hits        12760    12768    +8     
  Misses        920      920           
  Partials       36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[open-craft-grove]

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

[open-craft-grove]

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

[pomegranited]

Your fixes look good and work well @ChrisChV :)

But I don't know what's causing this, but when I try to view or load the library page using a small browser size (<667px wide), I get this error screen:

Is that something you can fix here too?

[ChrisChV]

Is that something you can fix here too?

@pomegranited Sorry I can't reproduce the bug. Could you send me a video of the bug?

[yusuf-musleh]

👍 @ChrisChV Looks good to me, and works well. Good work!

I also wasn't able to reproduce the bug you mentioned @pomegranited , might be related to a specific browser we need to check?

• I tested this: Followed testing instructions
• I read through the code
• I checked for accessibility issues
• Includes documentation

[bradenmacdonald]

Let's fix @pomegranited's issue in a separate PR, once we've figured it out. I also can't reproduce it, and we don't really support screen widths that narrow in this application anyways.

[openedx-webhooks]

@ChrisChV 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.