Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Policy: inconsistent types for timestamps (string vs. number) #432

Closed
ascherkus opened this issue Jan 24, 2020 · 3 comments · Fixed by #523
Closed

Policy: inconsistent types for timestamps (string vs. number) #432

ascherkus opened this issue Jan 24, 2020 · 3 comments · Fixed by #523
Assignees
@marie-x
Labels
bug Something isn't working Policy Specific to the Policy API
Milestone
1.0.0

Comments

@ascherkus
Copy link

Describe the bug
The examples contained in the policy README.md have all timestamps declared as strings, but the examples.md uses numbers.

To Reproduce
Steps to reproduce the behavior: N/A

Expected behavior
I believe for consistency across the MDS specification that timestamps are milliseconds represented as numbers.

Additional context
Came across this while prototyping a tool for #423.

Happy to send out a PR - just want clarification before doing so!
@marie-x
Copy link
Collaborator

marie-x commented Jan 24, 2020

Yes, we should be consistent. Good catch @ascherkus. Please send a PR while I look at the other two issues you filed. :)

@ascherkus
Copy link
Author

Will take a crack!

ascherkus added a commit to ascherkus/mobility-data-specification that referenced this issue Jan 24, 2020
@ascherkus
Policy: use a consistent definition for timestamps.
43585ff 
Aligns the Policy text specification for timestamps to the Provider and Agency
APIs, which use integer milliseconds from Unix epoch.

Fixes issue openmobilityfoundation#432.
@ascherkus ascherkus mentioned this issue Jan 24, 2020
Closed
@sarob sarob added bug Something isn't working Policy Specific to the Policy API labels Jan 27, 2020
@sarob sarob added this to the Future milestone Feb 1, 2020
@jfh01 jfh01 modified the milestones: Future, 1.0.0 Apr 9, 2020
@marie-x marie-x self-assigned this Apr 16, 2020
@schnuerle schnuerle linked a pull request Jun 12, 2020 that will close this issue
Policy: use a consistent definition for timestamps. #435
Closed
@schnuerle schnuerle mentioned this issue Jun 19, 2020
Merged
@schnuerle schnuerle linked a pull request Jun 19, 2020 that will close this issue
Policy: use a consistent definition for timestamps (recreation) #523
Merged
@schnuerle
Copy link
Member

This issue is closed with PR #523.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marie-x marie-x

Labels
bug Something isn't working Policy Specific to the Policy API
Projects
None yet
Milestone
1.0.0
5 participants
@jfh01 @ascherkus @marie-x @sarob @schnuerle