Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'other' option to vehicle_type #518

Closed
schnuerle opened this issue Jun 12, 2020 · 5 comments · Fixed by #534
Closed

Add 'other' option to vehicle_type #518

schnuerle opened this issue Jun 12, 2020 · 5 comments · Fixed by #534
Labels
Agency Specific to the Agency API enhancement New feature or request Policy Specific to the Policy API Provider Specific to the Provider API Schema Implications for JSON Schema or OpenAPI
Milestone

Comments

@schnuerle
Copy link
Member

Is your feature request related to a problem? Please describe.

Would like to align vehicle types between MDS and GBFS.

Currently GBFS v2.1rc has 5 types, and MDS 0.4.1 has 4 types.

They are the same except GBFS has an other type.

Describe the solution you'd like

Would like to add the other to vehicle_types. It seems valuable so you don't have to make up your own type or pigeon hole into one of the 4, for example if you want to do use MDS with a new vehicle type like dockless cars, drones, etc. Can be updated later away from other by providers/cities when the new vehicle type is added to the spec.

If possible, I'd like to include this in 1.0.0. Can be implemented in the Reconciliation PR #506.

Is this a breaking change

  • No, non-breaking

Impacted Spec

For which spec is this feature being requested?

  • agency
  • policy
  • provider

Describe alternatives you've considered

Do nothing, leave the feature specified as-is.

@schnuerle schnuerle added enhancement New feature or request Provider Specific to the Provider API minor update A change that is minor and should require little discussion, or is a maintenance/readme/typo update. labels Jun 12, 2020
@schnuerle schnuerle added this to the 1.0.0 milestone Jun 12, 2020
@thekaveman thekaveman added Agency Specific to the Agency API Schema Implications for JSON Schema or OpenAPI Policy Specific to the Policy API and removed minor update A change that is minor and should require little discussion, or is a maintenance/readme/typo update. labels Jun 12, 2020
@thekaveman
Copy link
Collaborator

Submitted a Draft PR for review against the Reconciliation work: lacuna-tech#14

@schnuerle
Copy link
Member Author

MobilityData said on a call the intention is catch new vehicle types until they can be added to future releases.

See line 270 in this PR change: https://github.com/NABSA/gbfs/pull/136/files#diff-b85f1f78eaba81b0af480ba6c878256eR270

Also note in this GBFS PR they are changing bike_id to vehicle_id to match MDS!

@schnuerle
Copy link
Member Author

Conversation 6/18 Provider WG call: Agreed this was a good thing to add.

@thekaveman
Copy link
Collaborator

Once #506 is merged, I'll submit a new PR with the same changes as the linked PR, into the MDS repo.

@schnuerle schnuerle linked a pull request Jun 26, 2020 that will close this issue
@schnuerle
Copy link
Member Author

Resolved and added with the #534 PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Agency Specific to the Agency API enhancement New feature or request Policy Specific to the Policy API Provider Specific to the Provider API Schema Implications for JSON Schema or OpenAPI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants