Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provider/Agency reconciliation #506

Merged

Conversation

marie-x
Copy link
Collaborator

@marie-x marie-x commented May 26, 2020

@marie-x marie-x requested a review from a team May 26, 2020 20:20
@marie-x marie-x requested a review from a team as a code owner May 26, 2020 20:20
@marie-x marie-x requested a review from a team May 26, 2020 20:20
@schnuerle
Copy link
Member

Thanks for this pull request for the API Reconciliation work! We'll discuss together on tomorrow's webinar - the audience is our working groups, but anyone can participate.

@marie-x
Copy link
Collaborator Author

marie-x commented May 26, 2020

Note: there are several unresolved naming issues to be considered, including unavailable vs. non_operational, and on_trip vs. in_trip vs. trip state.

@thekaveman
Copy link
Collaborator

thekaveman commented May 27, 2020

Suggestions:

  1. Move the shared content into General Information rather than another document.

  2. In the Vehicle Events table, list the Prior state column first, to show the state flow from left -> right.

@schnuerle
Copy link
Member

For the wording of on_trip vs. in_trip vs. trip state:

trip is argued because it is what is there now. on_trip is argued since it better aligns with the other changes in this PR.

My opinion is since this a breaking change anyway, the on_trip wording makes more sense for cities looking at it. Also echoed by Jascha, Max, and Jean Kao from Populus on the webinar.

Please leave a comment here if you have a differing opinion so we can discuss before on_trip gets approved.

@schnuerle
Copy link
Member

For the wording of unavailable vs. non_operational, it's mostly semantics and what word fits better in the defined situations.

I believe unavailable is the way to go since it's a bit broader in meaning.

Please leave a comment here if you have a differing opinion so we can discuss before unavailable gets approved.

@schnuerle schnuerle added Agency Specific to the Agency API Schema Implications for JSON Schema or OpenAPI Provider Specific to the Provider API State Machine Changes in the vehicle state events and state machine diagram labels May 27, 2020
@schnuerle schnuerle self-assigned this May 27, 2020
@schnuerle schnuerle added this to the 1.0.0 milestone May 27, 2020
policy/README.md Outdated Show resolved Hide resolved
provider/README.md Outdated Show resolved Hide resolved
provider/README.md Outdated Show resolved Hide resolved
provider/auth.md Outdated Show resolved Hide resolved
provider/README.md Show resolved Hide resolved
@thekaveman
Copy link
Collaborator

On one of the earlier Reconciliation calls, we talked about the idea of creating a mapping/transformation from the old style to this new proposed style - to help those with existing data get an idea of how to migrate. It doesn't seem like it should be part of this PR and live in the spec forever; maybe a Wiki page makes more sense? I'm imagining a plain language description + SQL script or similar, but open to any ideas.

@schnuerle
Copy link
Member

On one of the earlier Reconciliation calls, we talked about the idea of creating a mapping/transformation from the old style to this new proposed style - to help those with existing data get an idea of how to migrate. It doesn't seem like it should be part of this PR and live in the spec forever; maybe a Wiki page makes more sense? I'm imagining a plain language description + SQL script or similar, but open to any ideas.

I recall that too. I think a Wiki page is the place to accomplish this. At minimum a description of how to upgrade your old fields to align with these new fields - what gets created, copied, removed, etc. A few diagrams/charts would help.

Some SQL may be in order though I think it would be generic since we don't know what everyone is running. Maybe the above would be enough though.

@mobilitygirl
Copy link

Re: non-operational vs. unavailable

From our conversations with cities, non-operational is the term that the majority of transportation planners prefer for this vehicle state.

From talking with most public agencies, they need a term for which:
x + y = total vehicles in my public right of way

Many cities find the terms available and unavailable to be confusing because the majority of people naturally assume that available + unavailable = vehicles in the public right of way, because available and unavailable are literal antonyms of each other. (But this natural interpretation is incorrect based on current terms).

Hence the recommendation to use operational and non-operational after conversations facilitated by Toole Design and Populus with public agencies. These vehicle states are are subsets of "Deployed" vehicles, and are also consistent with what most other transportation systems would use to define such vehicles (e.g. the Federal Transit Administration, FAA, etc.)

@mobilitygirl
Copy link

The cities and non-profit organizations that reviewed and participated in the dialogue that led to the recommendation for the terms operational and non-operational include:

City of Bellevue, City of Tallahassee, Denver Regional Council of Governments, Miami-Dade County, City of Chicago, City of Portland, City of Seattle, Colorado Department of Transportation, District Department of San Diego Association of Governments

Transportation Sustainability Research Center at UC Berkeley, National League of Cities, New Urban Mobility Alliance, Shared-Use Mobility Center, OECD International Transport Forum, National Renewable Energy Laboratory

Their participants were primarily transportation planners, policymakers, and research scientists (in the case of research organizations), who are generally less represented in conversations on GitHub.

schnuerle
schnuerle previously approved these changes Jun 22, 2020
Copy link
Member

@schnuerle schnuerle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge to dev. Any objections please reply today.

thekaveman
thekaveman previously approved these changes Jun 22, 2020
@marie-x
Copy link
Collaborator Author

marie-x commented Jun 22, 2020

@billdirks I would propose deferring changes to support unauthorized movement to 1.1, as no specific proposal is on the table, and the community would not have time to digest it.

@billdirks
Copy link
Contributor

@Karcass Deferring to 1.1 sounds good to me. This is now being tracked in #527 (Thank you @thekaveman!)

@marie-x marie-x dismissed stale reviews from thekaveman and schnuerle via 581a363 June 25, 2020 16:09
schnuerle
schnuerle previously approved these changes Jun 25, 2020
Copy link
Member

@schnuerle schnuerle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to move forward.

provider/README.md Show resolved Hide resolved
provider/README.md Outdated Show resolved Hide resolved
@schnuerle schnuerle self-requested a review June 25, 2020 17:33
Copy link
Member

@schnuerle schnuerle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the final tweaks. We will get the rest resolved in the other PRs/issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Agency Specific to the Agency API Provider Specific to the Provider API Schema Implications for JSON Schema or OpenAPI State Machine Changes in the vehicle state events and state machine diagram
Projects
None yet
9 participants