add versioning for Agency and Policy API #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A minimal set of changes to add versioning to the Agency API and stay consistent with the Provider API.
|
|
Retzoh
commented
Feb 6, 2020
thekaveman
added
Agency
This commit just copies the Versioning section from the provider spec to a "General information" file.
|
@thekaveman @jrheard I have updated the PR to move the provider Versioning section to a separate general-information file and link it from the other APIs. Let me know what you think. |
Retzoh
changed the title
Retzoh
commented
Feb 18, 2020
Retzoh
commented
Feb 18, 2020
jrheard
previously approved these changes
Feb 18, 2020
thekaveman
approved these changes
Feb 19, 2020
|
@thekaveman this has been validated on the Agency side too. Can you merge it ? |
|
LGTM from the Agency/Policy side |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain pull request
This is a pull request attempting to solve #422 without introducing any breaking changes to the
providerAPI.Is this a breaking change
A breaking change would require consumers or implementors of the API to modify their code for it to continue to function (ex: renaming of a required field or the change in data type of an existing field). A non-breaking change would allow existing code to continue to function (ex: addition of an optional field or the creation of a new optional endpoint).
Impacted Spec
Which spec(s) will this pull request impact?
agency: adding versioning sectionpolicy: adding versioning sectionprovider: moving the versioning sectionAdditional context
None