Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agency: Vehicle Update response code should be 200 #467

Conversation

tonial
Copy link
Contributor

@tonial tonial commented Mar 11, 2020

Explain pull request

According to the RFC : https://tools.ietf.org/html/rfc7231#section-6.3.1
the HTTP response for an update (that does not create any object) can
either be 200 (OK) or 202 (ACCEPTED)
The later "indicates that the request has been
accepted for processing, but the processing has not been completed."

Since updating the vehicle_id should be quite fast, we should use a 200
response code.

Is this a breaking change

  • Yes, breaking (since providers may check the response code when sending data)

Impacted Spec

  • agency

Additional context

Add any other context or screenshots about the feature request here.

@tonial tonial requested a review from a team March 11, 2020 16:42
@tonial tonial requested a review from a team as a code owner March 11, 2020 16:42
@CLAassistant
Copy link

CLAassistant commented Mar 11, 2020

CLA assistant check
All committers have signed the CLA.

@tonial tonial changed the title agency: Vehicle Update repsonse code should be 200 agency: Vehicle Update response code should be 200 Mar 11, 2020
According to the RFC : https://tools.ietf.org/html/rfc7231#section-6.3.1
the HTTP response for an update (that does not create any object) can
either be 200 (OK) or 202 (ACCEPTED)
The later "indicates that the request has been
accepted for processing, but the processing has not been completed."

Since updating the vehicle_id should be quite fast, we should use a 200
response code.
@tonial tonial force-pushed the alaurent/agency_vehicle_update_response_status_code branch from 7959659 to e66cf5f Compare March 11, 2020 16:45
@sarob sarob added Agency Specific to the Agency API enhancement New feature or request labels Mar 22, 2020
@sarob sarob added this to the Future milestone Mar 22, 2020
@jfh01 jfh01 modified the milestones: Future, 1.0.0 Apr 9, 2020
@schnuerle schnuerle merged commit 65fb9e9 into openmobilityfoundation:dev Jun 11, 2020
@tonial tonial deleted the alaurent/agency_vehicle_update_response_status_code branch May 27, 2021 11:51
@tonial tonial restored the alaurent/agency_vehicle_update_response_status_code branch May 27, 2021 11:51
@tonial tonial deleted the alaurent/agency_vehicle_update_response_status_code branch May 27, 2021 11:54
@tonial tonial restored the alaurent/agency_vehicle_update_response_status_code branch May 27, 2021 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Agency Specific to the Agency API enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants