Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geographic Updates for Release #604

Merged
merged 8 commits into from
Dec 9, 2020
Merged

Geographic Updates for Release #604

merged 8 commits into from
Dec 9, 2020

Conversation

schnuerle
Copy link
Member

@schnuerle schnuerle commented Nov 19, 2020

Explain pull request

Addressing multiple Issues and conversations around geographic parts of the release and /geography:

  • Roll policy types into new geo type (geofence/policy_zone) Feedback on geography_type Field #588
  • Retire date optional Add retire_date as an optional field to Geography #590
  • Allowing Polygons - Need to clarify no points or specify in spec a buffer around any points. Geographic data in general info - polygon. Point in route for stop. Connect to geography for stop as a feature collection. Change example from point to polygons for stops in Geography. Change location field to describe polygon or point (just point now).

Is this a breaking change

  • No, not breaking

Impacted Spec

Which spec(s) will this pull request impact?

  • agency
  • policy
  • provider

@schnuerle schnuerle requested a review from a team as a code owner November 19, 2020 15:39
@schnuerle schnuerle added the Geography Items related to the Geography API label Nov 19, 2020
@schnuerle schnuerle added this to the 1.1.0 milestone Nov 19, 2020
general-information.md Outdated Show resolved Hide resolved
A change in retire date still requires a new geography id.  Note about what it means to retire.
Made stop location a simple point, and recommended using geography_id for a more accurate polygon definition. Fixed link to Point Feature from provider to this document.
@schnuerle
Copy link
Member Author

@thekaveman or @jfh01 can you review and approve changes please?

@schnuerle schnuerle merged commit c4e3d20 into dev Dec 9, 2020
@schnuerle schnuerle deleted the ms-geography-2 branch January 26, 2021 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Geography Items related to the Geography API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants