Add point accuracy & define optional point feature properties #73
Conversation
There was a problem hiding this comment.
I like this terminology, this is all really great clarification. Can you rebase on the latest master so we can see it in context?
Edit: a separate PR for #74 is probably best, I jumped the gun on that. But I still think Feature makes the most sense there.
ezheidtmann
force-pushed
the
add-point-accuracy-and-optional-properties
branch
from
a81a186
to
bace177
Compare
|
Thanks. Rebased. |
provider/README.md
Outdated
| To represent a route, MDS `provider` APIs should create a GeoJSON Feature Collection, which includes every observed point in the route. Each point is expressed as a GeoJSON `Feature` with a `Point` geometry. | ||
|
|
||
| Route point features must include at least a UTC timestamp and accuracy radius in the `properties` key. Optional fields may be omitted or use the `null` value. | ||
| >>>>>>> Add point accuracy & define optional point feature properties |
There was a problem hiding this comment.
It looks like you rebased, but didn't resolve the merge conflicts?
There was a problem hiding this comment.
Ha! Looks like I committed before I saved the resolution. Pushed again.
ezheidtmann
force-pushed
the
add-point-accuracy-and-optional-properties
branch
from
bace177
to
6110de1
Compare
|
sorry for the close - had some branch errors that required recreating master and that closed this PR. |
|
What changes are needed now? Another rebase? |
|
Is this PR still relevant? @thekaveman? |
|
|
|
Being addressed by #653. Please review that PR and leave comments there if interested. |
Addresses #59 and #51.
I used
horizontalAccuracybecause it's a good match toverticalAccuracy, but I don't feel strongly.