Add passenger-services to feature-modes branch #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on, add specificity to trip_id requirements for taxi, and add separate links to MM events and Taxi events
…descriptive description
…lity-options-in-trips-payload Rename accessibility_options_used -> accessibility_options in Trips payload
schnuerle
reviewed
Mar 30, 2022
schnuerle
reviewed
Mar 30, 2022
schnuerle
reviewed
Mar 30, 2022
schnuerle
reviewed
Mar 30, 2022
schnuerle
reviewed
Mar 30, 2022
schnuerle
reviewed
Mar 30, 2022
schnuerle
reviewed
Mar 30, 2022
schnuerle
reviewed
Mar 31, 2022
schnuerle
reviewed
Mar 31, 2022
| @@ -37,9 +45,24 @@ The `trip_attributes` array is not used with the micromobility mode. | |||
| The `vehicle_attributes` array may have the following key value pairs: | |||
|
|
|||
| - `year` (integer) | |||
| - `manufacturer` (string) | |||
| - `make` (string) | |||
There was a problem hiding this comment.
Are you changing this just because this is standard terminology for cars? I know 2.0 is breaking but should it stay manufacturer for consistency? Just checking, but I do like using make better I believe.
There was a problem hiding this comment.
Per @marie-x, "I wanted to do make and model because that seems more standard"
schnuerle
reviewed
Mar 31, 2022
schnuerle
reviewed
Mar 31, 2022
schnuerle
reviewed
Mar 31, 2022
marie-x
reviewed
Mar 31, 2022
| @@ -702,6 +716,7 @@ You may also show which APIs, endpoints, and fields your agency is serving to pr | |||
|
|
|||
| [Top][toc] | |||
|
|
|||
| [accessibility-options]: /general-information.md#accessibility-options | |||
There was a problem hiding this comment.
Todo: this section got refactored out - need to restore.
schnuerle
reviewed
Mar 31, 2022
schnuerle
changed the base branch from
feature-modes
to
feature-modes-passenger-services
|
There's a lot of general cleanup here (broken links, typos, removing TODOs, etc) so I'm merging to a new branch |
schnuerle
merged commit ba327d0
into
openmobilityfoundation:feature-modes-passenger-services
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THIS PR IS INCOMPLETE, AND WILL BE ACTIVELY UPDATED OVER TIME TO ALIGN WITH THE NEW MODES GUIDANCE.
MDS Pull Request
Explain pull request
This pull request represents some of the work E&A/LADOT has done for adding Taxis to MDS, while starting to shift some of its definitions and structures into accordance with the New Modes Draft guidance.
A few things worth noting prior to reading this PR:
This currently does not entirely match the guidance in the new modes documentation, but before this gets anywhere near merging, it will be updated.
Because E&A only uses the MDS Agency interface, this is all that we have written so far -- however, we fully intend to reflect the changes in MDS Provider as well prior to merging.
We had a really quick turn-around time for this following some of the new guidelines, and haven't been keeping this work updated as the guidelines have been drafted; so, please keep that and the above notes in mind as you review. This is supposed to serve as a launch point for discussion, demonstrating the work we have implemented to date, along with making some minor adaptations to match the new guidelines.
Is this a breaking change
This was designed to be entirely non-breaking for Micromobility Providers integrating with MDS Agency, and I believe that still holds true. If a Provider needs to start sending Taxi data, of course that will be new work, but that's to be expected. This would be breaking for an Agency which implements it (if they were to claim they supported Taxi), but if they only wish to support Micromobility, that should require no changes.
Impacted Spec
Which spec(s) will this pull request impact?
agencypolicyprovidereventually, but not in this initial draft.