-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add start_location and end_location to Trips #760
Conversation
…on, add specificity to trip_id requirements for taxi, and add separate links to MM events and Taxi events
…descriptive description
…/neil/extend-accessibility-options-in-trips-payload Rename accessibility_options_used -> accessibility_options in Trips payload
Also update agency name
I made some minor clarifications, and I think this is ready for WG review now. It will be important to add this to dev if ready to align with Agency/Provider Unification work. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging to latest feature branch with work in progress, instead of dev.
Thank you for your work here! Due to a technical issue around the signing of our license agreement by a GitHub user who's account/email is changed, I am adding this change here to our latest feature branch with this commit. |
Explain pull request
SFMTA collects MDS trip data from its E-Moped Parking Permit Program, but only requires the start and end points of each trip, and specifically disallows the intermediate points that describe the routing of each trip. This is because we don't currently have a need for this data. SFMTA expresses this requirement in its permit language by saying "the route field shall only contain the start and end points of the trip."
The Policy Requirements endpoint allows agencies to indicate which fields are required and disallowed. In the Trips endpoint, the start and end points/time are described by the start_time, end_time, and route fields. If the route field is disallowed, the start_time and end_time fields still describe the times that trips started and ended, but the ability to communicate location is removed.
Adding start_location and end_location as optional fields would preserve the ability to communicate start and end points/times without having the route field.
Is this a breaking change
If the new fields are optional, then I don't think this is breaking.
Impacted Spec
Which spec(s) will this pull request impact?
provider