Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Modes - Delivery #778

Closed
wants to merge 20 commits into from
Closed

Feature: Modes - Delivery #778

wants to merge 20 commits into from

Conversation

tristan-charreton
Copy link
Contributor

Explain pull request

Work on deliveries to incorporate into Modes

Is this a breaking change

  • Yes, breaking

Impacted Spec

Which spec(s) will this pull request impact?

  • agency
  • policy
  • provider

tristan-charreton and others added 18 commits June 15, 2022 10:46
@tristan-charreton tristan-charreton requested a review from a team as a code owner July 19, 2022 16:49
@CLAassistant
Copy link

CLAassistant commented Jul 19, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

@schnuerle schnuerle added Modes New modes that MDS can support (carshare, passenger services, delivery robots, etc) Delivery Robots Delivery Robots mode: sidewalk, autonomous, remote labels Aug 4, 2022
@schnuerle schnuerle marked this pull request as draft August 11, 2022 16:21
@schnuerle schnuerle changed the base branch from feature-modes to feature-modes-passenger-services September 8, 2022 16:31
@schnuerle
Copy link
Member

@tristan-charreton Can you make sure the 'Allow Edits by Maintainers' checkbox in your pull request? That will allow me to clean up some of your work to align to other parts of the modes work. See if you can edit the PR and check it. If not, you will have to delete this PR then recreate with a new PR.

See bottom of this screenshot:

Screen Shot 2022-09-08 at 3 26 13 PM

@schnuerle schnuerle changed the base branch from feature-modes-passenger-services to dev September 9, 2022 01:50
@schnuerle schnuerle changed the title Feature modes delivery Feature: Modes - Delivery Sep 9, 2022
@tristan-charreton tristan-charreton marked this pull request as ready for review September 12, 2022 08:34
@tristan-charreton tristan-charreton marked this pull request as draft September 12, 2022 08:35
@tristan-charreton
Copy link
Contributor Author

Closing this PR before recreating it to allow maintainers to edit.

@tristan-charreton
Copy link
Contributor Author

Hello @schnuerle
I reopen the PR as even when creating a new PR, I do not find the "allow edits by maintainers" checkbox.
Checkbox

@schnuerle
Copy link
Member

@tristan-charreton I'm not sure why this isn't showing up for you, sorry! It has happened before. I think it's due to permissions/settings on the source organization/repo/branch on GitHub, in this case https://github.com/kiwibot-data/mobility-data-specification/tree/feature-modes-delivery

I know it would work if you took that Kiwibot branch and cloned it to your own account, then used that branch to make the pull request.

@schnuerle schnuerle mentioned this pull request Sep 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Delivery Robots Delivery Robots mode: sidewalk, autonomous, remote Modes New modes that MDS can support (carshare, passenger services, delivery robots, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tristan-charreton @CLAassistant @schnuerle @alesantiago98 @JuanCarlos-TiqueRangel