-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modes Feedback and Final Changes #801
Conversation
The MDS Modes work looks good and Ride Report will be using MDS 2.0 for micromobility and car share modes. Thanks for putting this together! |
The MDS modes work looks fantastic! SFMTA will use the MDS 2.0 passenger services mode for our Taxi reporting. Two small comments/questions:
|
fix spelling error with provider
I think we could add data_provider_id to the base. This is happening in micromoblity too with newer companies, where a third party is doing the MDS data feeds on behalf of an operator. Either way, I wonder if they should go in the same providers.csv file, or be a new file (like we did with agencies.csv) called data_operators.csv or something? Could be that third party software companies could be on this list too. If not separate then data-only software companies will be added to companies operating in the PROW with no differentiation (unless we add a flag or something, but then maybe it should be a separate file if that's required). UPDATE: see this Issue for the changes I made to add this to the MDS base #805 @alexdemisch
Agree paratransit should be be removed. Are there other values or fields here that people don't think will apply to car share and should be removed? UPDATE: made these updates and a few other minor ones. |
This looks good! - Nivedya Madankara Kottayi, SANDAG. |
Looks good to me. Thanks for all the hard work on this. - Emmett, Superpedestrian. |
Looks great! |
In the passenger services mode, is there currently a way to measure trip requests not fulfilled? What about wheelchair accessible vehicle trip requests not fulfilled? I recall talking about this early on in the modes work, but can't recall anything recent. |
It looks great! - Andrine, City of Oslo |
@alexdemisch I think this is possible with MDS currently. Eg, you can make a reservation, but then it can be cancelled by someone before the trip starts, usually at no cost. There are some additional options specifically in the Passenger Services Mode that allow for different kinds of event cancellation tracking, which I think cover all the bases:
|
For the Delivery Robots Mode:
|
Hi @Aileen1Zhong those are good questions thanks for sharing! Trade secrets and privacy are similar to what's been brought up around MDS for micromobility over the years. I've summarized your comment and some relevant MDS resources in discussion #808 where we can all dig in more deeply together with the Working Group and Privacy Committee. Please head here for the discussion, and we can bring back decisions here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM!!! 🚀
Since the only open discussion point now after the month review is the discussion about delivery robots, I'm going to merge this request in the development branch so we can focus at new pull request on that issue, and also work to incorporate other changes like the Agency/Provider unification work. Will comment again here when it's ready. Thank you all for your reviews and feedback! |
I've created pull request #812 that adds |
Looks good to Blue Systems, looking forward to using with the Delivery robots first, and other services in the future. |
To close the loop here on the comment from @Aileen1Zhong, based on the robust discussion in #808, the consensus is that MDS already has good guidance and existing tools to limit data fields when needed for any reason. Those built-in MDS tool are:
|
Explain pull request
To collect feedback and incorporate final changes into the Modes work for the MDS 2.0 release candidate.
Is this a breaking change
Impacted Spec
Which spec(s) will this pull request impact?
Additional context
Please review and leave general feedback here as comments, or inline feedback by looking at the PR changes. You can browse the modes work in the
feature-modes-2
feature branch.Note there are some areas that specifically need feedback or aren't complete like: