Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 'rate' rule-type, since we can put rate_amount on any rule #806

Closed
wants to merge 8 commits into from
Closed

Remove 'rate' rule-type, since we can put rate_amount on any rule #806

wants to merge 8 commits into from

Conversation

marie-x
Copy link
Collaborator

@marie-x marie-x commented Dec 6, 2022 •
edited
Loading

MDS Pull Request

Explain pull request

Removing the rate rule-type from Policy, as the notion of rate_amount etc. is available on all other rule-types.

Is this a breaking change

  • Yes, breaking (removing a beta feature)

Impacted Spec

Which spec(s) will this pull request impact?

  • policy

Additional context

Addresses #662, #674, and #704

@schnuerle schnuerle added the Policy Specific to the Policy API label Dec 6, 2022
@schnuerle schnuerle added this to the 2.0.0 milestone Dec 6, 2022
@schnuerle
Copy link
Member

Could you see how this PR relates to the following issues, if at all? #662 #663 #704

@jean-populus
Copy link
Collaborator

Thanks for doing this @marie-x ! I think you caught everything on my list wrt rates. Wondering if you wanted to also update the Policy Examples at the same time?

@marie-x
Copy link
Collaborator Author

marie-x commented Dec 6, 2022

Addresses #662 and #704 but not #663

@marie-x
Copy link
Collaborator Author

marie-x commented Dec 6, 2022

Thanks for doing this @marie-x ! I think you caught everything on my list wrt rates. Wondering if you wanted to also update the Policy Examples at the same time?

Yes! I should definitely do that.

@marie-x marie-x marked this pull request as ready for review December 7, 2022 19:48
@marie-x marie-x requested a review from a team as a code owner December 7, 2022 19:48
@marie-x marie-x changed the title [DRAFT] remove 'rate' rule-type, since we can put rate_amount on any rule Remove 'rate' rule-type, since we can put rate_amount on any rule Dec 7, 2022
@schnuerle
Copy link
Member

schnuerle commented Dec 15, 2022 •
edited
Loading

I think once the conflicts are resolved we can merge this to dev, @marie-x. The schemas are less important as we will be moving to OpenAPI for 2.0.

@jean-populus jean-populus mentioned this pull request Dec 19, 2022
Closed
@schnuerle
Copy link
Member

@jean-populus could you resolve the conflicts with the policy examples please?

@jean-populus
Copy link
Collaborator

jean-populus commented Jan 9, 2023 via email •
edited by schnuerle
Loading

@schnuerle schnuerle linked an issue Jan 9, 2023 that may be closed by this pull request
Remove "rate" as a rule type #662
Closed
schnuerle and others added 2 commits January 9, 2023 20:44
@schnuerle
Upgrading version
3a18f10
@marie-x
Merge branch 'dev' into feature-remove-rate-policy-rule-type
45aad59 
# Conflicts:
#	policy/examples/README.md
#	policy/examples/metered-parking-fees.json
#	policy/examples/per-trip-fees.json
#	policy/examples/vehicle-row-fees.json
@marie-x marie-x closed this Jan 11, 2023
@marie-x marie-x deleted the feature-remove-rate-policy-rule-type branch January 11, 2023 17:00
@schnuerle schnuerle removed this from the 2.0.0 milestone Jan 11, 2023
@schnuerle schnuerle removed a link to an issue Jan 18, 2023
Remove "rate" as a rule type #662
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schnuerle schnuerle schnuerle left review comments

Assignees
No one assigned
Labels
Policy Specific to the Policy API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marie-x @schnuerle @jean-populus