-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OTPL-6466] Using PostgreSQLContainer as a back end with same API #164
Conversation
Revise README, to acccount for the changes |
I believe EmbeddedUtil can be deleted and org tukaani xz can be removed from dependency? |
Delete embedded util Update to POM 308 (which pulls testcontainer update along)
README.md
Outdated
@@ -48,31 +48,22 @@ independent databases gives you. | |||
|
|||
## Postgres version | |||
|
|||
The JAR file contains bundled version of Postgres. You can pass different Postgres version by implementing [`PgBinaryResolver`](src/main/java/com/opentable/db/postgres/embedded/PgBinaryResolver.java). | |||
It is possible to change postgres version: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adapt some of my wording in CHANGELOG. In particular you should note what. no longer exists
- Support for a local postgres (for now)
- any other config options that changed.
pom.xml
Outdated
@@ -31,7 +31,7 @@ | |||
|
|||
<groupId>com.opentable.components</groupId> | |||
<artifactId>otj-pg-embedded</artifactId> | |||
<version>0.13.5-SNAPSHOT</version> | |||
<version>1.01.1-SNAPSHOT</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason this isn't 1.0.0?
pom.xml
Outdated
<version>${dep.testcontainers.version}</version> | ||
<exclusions> | ||
<exclusion> | ||
<groupId>junit</groupId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dumb question, why did this need to be excluded? To make it optional which version I'm guessing?
|
||
lock(); | ||
startPostmaster(connectConfig); | ||
private List<String> createInitOptions(final Map<String, String> localeConfig) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is confusing. Note under createConfigIOptions we have a hasmap called initOptions and under createInitOptions we have a localeOptions.
Also what is the distinction?
src/main/java/com/opentable/db/postgres/junit5/SingleInstancePostgresExtension.java
Show resolved
Hide resolved
Pass URI instead port. This removes "localhost" assumption and will allow to use remote docker.
1) timeout tweaks 2) removed URIBuilder usage
1. Java 8 compatibility for now - see changes in JdbcUrlUtils 2. Change POM version to 1.00.RC2-SNAPSHOT
* 1.0.0 candidate fixes * Change to 60s wait * Incorporate Dmitry's proposed changes * Add more information to README.md * Minor improvements allowing future BindMode exposure * Make this public * ok pmd ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.