[OTPL-6466] Using PostgreSQLContainer as a back end with same API #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkaukov
changed the title
dkaukov
changed the title
apara
approved these changes
Dec 23, 2021
|
Revise README, to acccount for the changes |
|
I believe EmbeddedUtil can be deleted and org tukaani xz can be removed from dependency? |
Delete embedded util Update to POM 308 (which pulls testcontainer update along)
mikebell90
reviewed
Jan 10, 2022
README.md
Outdated
| @@ -48,31 +48,22 @@ independent databases gives you. | |||
|
|
|||
| ## Postgres version | |||
|
|
|||
| The JAR file contains bundled version of Postgres. You can pass different Postgres version by implementing [`PgBinaryResolver`](src/main/java/com/opentable/db/postgres/embedded/PgBinaryResolver.java). | |||
| It is possible to change postgres version: | |||
There was a problem hiding this comment.
Adapt some of my wording in CHANGELOG. In particular you should note what. no longer exists
- Support for a local postgres (for now)
- any other config options that changed.
mikebell90
reviewed
Jan 10, 2022
pom.xml
Outdated
| @@ -31,7 +31,7 @@ | |||
|
|
|||
| <groupId>com.opentable.components</groupId> | |||
| <artifactId>otj-pg-embedded</artifactId> | |||
| <version>0.13.5-SNAPSHOT</version> | |||
| <version>1.01.1-SNAPSHOT</version> | |||
There was a problem hiding this comment.
Any reason this isn't 1.0.0?
mikebell90
reviewed
Jan 10, 2022
pom.xml
Outdated
| <version>${dep.testcontainers.version}</version> | ||
| <exclusions> | ||
| <exclusion> | ||
| <groupId>junit</groupId> |
There was a problem hiding this comment.
Dumb question, why did this need to be excluded? To make it optional which version I'm guessing?
mikebell90
reviewed
Jan 10, 2022
|
|
||
| lock(); | ||
| startPostmaster(connectConfig); | ||
| private List<String> createInitOptions(final Map<String, String> localeConfig) { |
There was a problem hiding this comment.
This is confusing. Note under createConfigIOptions we have a hasmap called initOptions and under createInitOptions we have a localeOptions.
Also what is the distinction?
mikebell90
reviewed
Jan 10, 2022
src/main/java/com/opentable/db/postgres/junit5/SingleInstancePostgresExtension.java
Show resolved
Hide resolved
Pass URI instead port. This removes "localhost" assumption and will allow to use remote docker.
1) timeout tweaks 2) removed URIBuilder usage
1. Java 8 compatibility for now - see changes in JdbcUrlUtils 2. Change POM version to 1.00.RC2-SNAPSHOT
* 1.0.0 candidate fixes * Change to 60s wait * Incorporate Dmitry's proposed changes * Add more information to README.md * Minor improvements allowing future BindMode exposure * Make this public * ok pmd ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.