Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix spec char issue #235

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fix spec char issue #235

wants to merge 7 commits into from

Conversation

ivanovSPvirtru
Copy link
Contributor

No description provided.

@ivanovSPvirtru ivanovSPvirtru requested a review from a team as a code owner September 6, 2023 09:23
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

If these changes look good, signoff on them with:

git pull && git commit --amend --signoff && git push --force-with-lease origin

If they aren't any good, please remove them with:

git pull && git reset --hard HEAD~1 && git push --force-with-lease origin

@ivanovSPvirtru ivanovSPvirtru force-pushed the feature/special_char_fix branch 2 times, most recently from ff4d272 to dc93b78 Compare September 6, 2023 11:41
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

If these changes look good, signoff on them with:

git pull && git commit --amend --signoff && git push --force-with-lease origin

If they aren't any good, please remove them with:

git pull && git reset --hard HEAD~1 && git push --force-with-lease origin

const result = [start];
if (end) {
result.push(end);
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because [number, number | undefined] is not the same with [number, number?]

pflynn-virtru
pflynn-virtru previously approved these changes Sep 6, 2023
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

If these changes look good, signoff on them with:

git pull && git commit --amend --signoff && git push --force-with-lease origin

If they aren't any good, please remove them with:

git pull && git reset --hard HEAD~1 && git push --force-with-lease origin

@ivanovSPvirtru ivanovSPvirtru force-pushed the feature/special_char_fix branch 2 times, most recently from 1e1beb6 to ffec1d9 Compare September 8, 2023 10:06
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

If these changes look good, signoff on them with:

git pull && git commit --amend --signoff && git push --force-with-lease origin

If they aren't any good, please remove them with:

git pull && git reset --hard HEAD~1 && git push --force-with-lease origin

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

If these changes look good, signoff on them with:

git pull && git commit --amend --signoff && git push --force-with-lease origin

If they aren't any good, please remove them with:

git pull && git reset --hard HEAD~1 && git push --force-with-lease origin

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

If these changes look good, signoff on them with:

git pull && git commit --amend --signoff && git push --force-with-lease origin

If they aren't any good, please remove them with:

git pull && git reset --hard HEAD~1 && git push --force-with-lease origin

Signed-off-by: sivanov <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Sep 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

87.0% 87.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants