allow forward_fn to accept more arguments #1803
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjurbanski-reef
force-pushed
the
allow_more_params
branch
from
55704e9
to
b823cf0
Compare
|
@mjurbanski-reef thank you! We will test this out to ensure backwards compatibility. |
|
@mjurbanski-reef we plan on getting this into |
|
superseded by #1822 which includes other related changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AFAIK there is no downside, and it does allow some extra innovation when handling request by allowing to monitor HTTP headers or other params etc directly in
forward_fn. This also helps with debugging.While enabling it, I refactored this function a little to reduce code duplication & improve the readability of it.