New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support root weights #2021

Open

open-junius wants to merge 32 commits into staging from junius/set_root_weigths

open-junius commented Jun 13, 2024 •

edited

Loading

The PR is a part of #1932

open-junius added 2 commits

June 13, 2024 20:41


          support root weights

5e12c23


          revert wrong input

9bbbd79

open-junius self-assigned this

open-junius added 2 commits

June 13, 2024 21:22


          revert wrong format

9496b69


          revert wrong format

1736bc1

camfairchild requested changes

View reviewed changes

Collaborator

camfairchild left a comment

I believe this is already covered by another merged PR as well

bittensor/subtensor.py Outdated

@@ @@ -874,18 +874,19 @@ def _do_set_weights( @@
                       def make_substrate_call_with_retry():
                           call = self.substrate.compose_call(
                               call_module="SubtensorModule",
-                              call_function="set_weights",

Collaborator

camfairchild Jun 13, 2024

This is not the correct place to implement this.

camfairchild added the do not merge label

open-junius marked this pull request as draft

June 13, 2024 16:13

open-junius added 5 commits

June 14, 2024 13:32


          Merge branch 'staging' into junius/set_root_weigths

5c3ae14


          revert subtensor change

4f15916


          revert change


          add min stake check

4664d53


          fix test case

c258285

open-junius marked this pull request as ready for review

June 14, 2024 11:39

open-junius mentioned this pull request

hotfix/set-root-weights opentensor/subtensor#527

Merged

RomanCh-OT approved these changes

View reviewed changes

Contributor

RomanCh-OT left a comment

Left a few comments regarding Cortex Code Style standard.

Overall LGTM

tests/e2e_tests/subcommands/root/test_root_boost_weights.py Show resolved Hide resolved

tests/e2e_tests/utils.py Outdated Show resolved Hide resolved

tests/e2e_tests/utils.py Outdated Show resolved Hide resolved

open-junius added 2 commits

June 15, 2024 01:14


          add comments

455ac5e


          merge with target branch

fa5f02e

opendansor reviewed

View reviewed changes

tests/e2e_tests/subcommands/root/test_root_boost_weights.py Show resolved Hide resolved

opendansor reviewed

View reviewed changes

tests/e2e_tests/subcommands/stake/test_show.py Outdated Show resolved Hide resolved

opendansor reviewed

View reviewed changes

tests/e2e_tests/subcommands/stake/test_show.py Outdated Show resolved Hide resolved

opendansor requested changes

View reviewed changes

Contributor

opendansor left a comment

Please go over the tests again and make sure that 1) that feature doesnt already have a dedicated test and 2) you assert results in the test.

opendansor reviewed

View reviewed changes

tests/e2e_tests/subcommands/root/test_root_boost_weights.py Outdated Show resolved Hide resolved

open-junius added 3 commits

June 17, 2024 08:45


          Merge branch 'staging' into junius/set_root_weigths

817fcec


          remove test_show case

f6d4bd7


          add state check

9715f2c

open-junius requested a review from opendansor

June 17, 2024 02:59

opendansor reviewed

View reviewed changes

tests/e2e_tests/utils.py Outdated Show resolved Hide resolved

opendansor reviewed

View reviewed changes

tests/e2e_tests/subcommands/root/test_root_boost_weights.py Outdated Show resolved Hide resolved

opendansor reviewed

View reviewed changes

tests/e2e_tests/subcommands/root/test_root_boost_weights.py Outdated Show resolved Hide resolved

opendansor reviewed

View reviewed changes

tests/e2e_tests/subcommands/root/test_root_boost_weights.py Outdated

+                  setup_wallet,
+                  sudo_call_set_network_limit,
+                  sudo_call_set_weight_limit,
+                  sudo_call_set_min_stake,

Contributor

opendansor Jun 17, 2024

All of these sudo_call's need to be replaced with Btcli commands.

Contributor

RomanCh-OT Jun 18, 2024

All of these sudo_call's need to be replaced with Btcli commands.

It would be very helpful if you could leave a link to a similar test case that has already been implemented

open-junius and others added 10 commits

June 18, 2024 17:43


          try sudo command

fba71ea


          Merge branch 'staging' into junius/set_root_weigths

92d1768


          add network rate limit hypermparams


          no btcli available

7b4dec6


          add sudo set without netuid

7fa02d0


          Merge branch 'staging' into junius/set_root_weigths

9735a27


          fix spelling

ffc693f


          Merge branch 'staging' into junius/set_root_weigths

577c2a3


          Merge branch 'staging' into junius/set_root_weigths

af96b9f


          Merge branch 'staging' into junius/set_root_weigths

thewhaleking requested changes

View reviewed changes

bittensor/commands/network.py Outdated Show resolved Hide resolved

bittensor/extrinsics/network.py Outdated Show resolved Hide resolved

tests/e2e_tests/subcommands/root/test_root_boost_weights.py Show resolved Hide resolved

tests/e2e_tests/subcommands/root/test_root_boost_weights.py Outdated Show resolved Hide resolved

tests/e2e_tests/subcommands/root/test_root_boost_weights.py Outdated Show resolved Hide resolved

opendansor and others added 8 commits

June 25, 2024 18:55


          add commentary.

a4ae8fc


          revert sudo command

fc9f38c


          revert network py

550368a


          test passed

0f1326b


          clean code

df79737


          Merge branch 'staging' into junius/set_root_weigths

d76f796


          update comments

62cfeb7


          Merge branch 'staging' into junius/set_root_weigths

d647ec8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment