Skip to content

Commit

Permalink
tests: disable RACF-KDFAES format while fuzzing
Browse files Browse the repository at this point in the history 
It's difficult to reproduce the fuzzLite failure elsewhere.
At the very least we are documenting the formats that fail.

```
Testing: RACF-KDFAES [KDFAES (DES + HMAC-SHA256/64 + AES-256)]...
racf_kdfaes_fmt_plug.c:372:23: runtime error: left shift of 238 by 24 places cannot be represented in type 'int'
```

Signed-off-by: Claudio André <[email protected]>
  • Loading branch information
@claudioandre-br
claudioandre-br committed May 12, 2024
1 parent 7a91507 commit 770c8e3
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion .clusterfuzzlite/build.sh
View file
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ if [[ "$SANITIZER" == "address" ]]; then
# Asan
./configure --enable-asan
make -sj4

cp ../run/john "$OUT"/

echo "------------------ Disable problematic formats -------------------"
Expand All @@ -47,6 +46,11 @@ if [[ "$SANITIZER" == "undefined" ]]; then
# Ubsan
./configure --enable-ubsan
make -sj4
cp ../run/john "$OUT"/

echo "------------------ Disable problematic formats -------------------"
echo '[Local:Disabled:Formats]' >>../run/john-local.conf
echo 'RACF-KDFAES = Y' >>../run/john-local.conf

echo "------------------------- UBSAN fuzzing --------------------------"
echo "$ JtR UBSAN --test=0"
Expand Down

1 comment on commit 770c8e3

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@check-spelling-bot Report

🔴 Please review

See the 📜action log or 📝 job summary for details.

Unrecognized words (1)

KDFAES

Previously acknowledged words that are now absent dsaltares virusscan 🫥
To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands

... in a clone of the [email protected]:openwall/john-packages.git repository
on the fuzz branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/26b46adbdebd5dd0b34c7155113d50c40f43fb22/apply.pl' |
perl - 'https://github.com/openwall/john-packages/actions/runs/9051799057/attempts/1'
Available 📚 dictionaries could cover words (expected and unrecognized) not in the 📘 dictionary

This includes both expected items (238) from .github/actions/spelling/expect.txt and unrecognized words (1)

Dictionary Entries Covers Uniquely
cspell:node/dict/node.txt 891 22 5
cspell:filetypes/filetypes.txt 264 10 4
cspell:php/dict/php.txt 1689 14 3
cspell:python/src/python/python-lib.txt 2417 14 3
cspell:k8s/dict/k8s.txt 153 10 3

Consider adding them (in .github/workflows/spelling.yml) for uses: check-spelling/check-spelling@26b46adbdebd5dd0b34c7155113d50c40f43fb22 in its with:

      with:
        extra_dictionaries:
          cspell:node/dict/node.txt
          cspell:filetypes/filetypes.txt
          cspell:php/dict/php.txt
          cspell:python/src/python/python-lib.txt
          cspell:k8s/dict/k8s.txt

To stop checking additional dictionaries, add (in .github/workflows/spelling.yml) for uses: check-spelling/check-spelling@26b46adbdebd5dd0b34c7155113d50c40f43fb22 in its with:

check_extra_dictionaries: ''

Please sign in to comment.