Fixes type annotation overload of dlpack_managed_tensor_to_buffer in python/xla_extension
#10433
+7
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddunl
approved these changes
Mar 12, 2024
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Mar 12, 2024
…o_buffer` in `python/xla_extension` Imported from GitHub PR openxla/xla#10433 Encountered bug in google/jax#20175 (see this [comment](google/jax#20175 (comment))). This adjusts the stub file to properly overload `dlpack_managed_tensor_to_buffer` so that both signatures can be checked against. Copybara import of the project: -- 75cabb5149b4a0bdd9e819fac0ea6a0ba756bff6 by Meekail Zain <[email protected]>: Update Merging this change closes #10433 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#10433 from Micky774:type_update 75cabb5149b4a0bdd9e819fac0ea6a0ba756bff6 PiperOrigin-RevId: 615173747
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Mar 14, 2024
…o_buffer` in `python/xla_extension` Imported from GitHub PR openxla/xla#10433 Encountered bug in google/jax#20175 (see this [comment](google/jax#20175 (comment))). This adjusts the stub file to properly overload `dlpack_managed_tensor_to_buffer` so that both signatures can be checked against. Copybara import of the project: -- 75cabb5149b4a0bdd9e819fac0ea6a0ba756bff6 by Meekail Zain <[email protected]>: Update Merging this change closes #10433 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#10433 from Micky774:type_update 75cabb5149b4a0bdd9e819fac0ea6a0ba756bff6 PiperOrigin-RevId: 615173747
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Mar 14, 2024
…o_buffer` in `python/xla_extension` Imported from GitHub PR openxla/xla#10433 Encountered bug in google/jax#20175 (see this [comment](google/jax#20175 (comment))). This adjusts the stub file to properly overload `dlpack_managed_tensor_to_buffer` so that both signatures can be checked against. Copybara import of the project: -- 75cabb5149b4a0bdd9e819fac0ea6a0ba756bff6 by Meekail Zain <[email protected]>: Update Merging this change closes #10433 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#10433 from Micky774:type_update 75cabb5149b4a0bdd9e819fac0ea6a0ba756bff6 PiperOrigin-RevId: 615173747
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Mar 15, 2024
…o_buffer` in `python/xla_extension` Imported from GitHub PR openxla/xla#10433 Encountered bug in google/jax#20175 (see this [comment](google/jax#20175 (comment))). This adjusts the stub file to properly overload `dlpack_managed_tensor_to_buffer` so that both signatures can be checked against. Copybara import of the project: -- 75cabb5149b4a0bdd9e819fac0ea6a0ba756bff6 by Meekail Zain <[email protected]>: Update Merging this change closes #10433 PiperOrigin-RevId: 615973838
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encountered bug in google/jax#20175 (see this comment).
This adjusts the stub file to properly overload
dlpack_managed_tensor_to_bufferso that both signatures can be checked against.