-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring of Logger module #1785
Conversation
Codecov ReportBase: 70.35% // Head: 70.42% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1785 +/- ##
==========================================
+ Coverage 70.35% 70.42% +0.07%
==========================================
Files 23 23
Lines 2587 2597 +10
Branches 591 594 +3
==========================================
+ Hits 1820 1829 +9
Misses 661 661
- Partials 106 107 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
6a8537a
to
58155f8
Compare
58155f8
to
e74f451
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- the value given should be checked,
--verbose=ddd
just pass. Like any other argument it should be check and if wrong an error should be displayed and mwoffliner should exit. - In the usage, default value if nothing specified should be documented.
- It should be explain as well that the chosen level print also all the level greather than this. So if you should
warn
, you will getwarn
anderrors
- Everything should be written to STDOUT except the errors, which should be printed to the STDERR
- Not sure, but I think default behaviour should print error, so like
--verbose=error
. Doing so would imply to not have any more solution for a "silent" mode... maybe a--verbose=none
would be a solution?
Added sanitizing for verbose option. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase and resolve conflicts, have also left a small style feedback
Use ['info', 'log', 'warn', 'error'] as values for --verbose
067978a
to
df369db
Compare
df369db
to
b26ec2e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Use ['info', 'log', 'warn', 'error'] as values for --verbose
fixes: #674