-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup AxiosError redundant message. #1795
Conversation
@FledgeXu Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add tests for cases of fully filled err response and if the error object is filled only partially.
I would be OK to only unit test the cleanup function. |
Ok, I will add it later. |
I added a unit test case for cleanup function and I also adjusted the location of the function. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportBase: 70.40% // Head: 70.35% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1795 +/- ##
==========================================
- Coverage 70.40% 70.35% -0.06%
==========================================
Files 23 23
Lines 2585 2587 +2
Branches 591 591
==========================================
Hits 1820 1820
- Misses 659 661 +2
Partials 106 106
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Thanks for your help! |
Fix: #1792