Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take the protocol for logo URL from parameter --mwUrl #1800

Merged
merged 1 commit into from
Mar 1, 2023
Merged

Conversation

pavel-karatsiuba
Copy link
Contributor

MediaWiki doesn't allow downloading the logo from a URL with the http protocol.
Take the protocol for logo URL from parameter --mwUrl

#1799

@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change

Comparison is base (ad56c6b) 70.42% compared to head (74d934d) 70.42%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1800   +/-   ##
=======================================
  Coverage   70.42%   70.42%           
=======================================
  Files          23       23           
  Lines        2597     2597           
  Branches      594      594           
=======================================
  Hits         1829     1829           
  Misses        661      661           
  Partials      107      107           
Impacted Files Coverage Δ
src/mwoffliner.lib.ts 72.18% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pavel-karatsiuba pavel-karatsiuba marked this pull request as draft March 1, 2023 18:10
@pavel-karatsiuba pavel-karatsiuba marked this pull request as ready for review March 1, 2023 18:44
@kelson42 kelson42 merged commit 2232903 into main Mar 1, 2023
@kelson42 kelson42 deleted the logo-protocol branch March 1, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants