Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unrecognized option --authcode #488

Closed
qrkourier opened this issue Sep 15, 2022 · 1 comment · Fixed by #546
Closed

unrecognized option --authcode #488

qrkourier opened this issue Sep 15, 2022 · 1 comment · Fixed by #546
Labels
hacktoberfest

Comments

@qrkourier
Copy link
Member

Advertised long form --authcode is unrecognized, but the short form -c works.

❯ /opt/openziti/bin/ziti-edge-tunnel remove_mfa --identity /opt/openziti/etc/identities/fgalaxy-laptop.json --authcode 041595
remove_mfa: unrecognized option '--authcode'
Unknown option '?'

❯ /opt/openziti/bin/ziti-edge-tunnel remove_mfa --help
ziti-edge-tunnel remove_mfa: Removes MFA registration from the controller
usage: ziti-edge-tunnel remove_mfa [-i <identity>] [-c <code>]

        -i|--identity   identity info for removing mfa
        -c|--authcode   auth code to verify mfa login
szymonnogiec added a commit to szymonnogiec/ziti-tunnel-sdk-c that referenced this issue Nov 7, 2022
@szymonnogiec
Fix --authcode option parsing.
de9e41d 
Resolves openziti#488 issue. The checks for opts were wrong in 5 functions:
verify/remove/submit_mfa & generate/get_mfa_codes. All of them
expected long version of the opt to be '--code', instead of '--authcode' as
the docs say.
@szymonnogiec szymonnogiec mentioned this issue Nov 7, 2022
Merged
@szymonnogiec
Copy link
Contributor

Hey, I've fixed that in the PR: #546

scareything added a commit that referenced this issue Nov 7, 2022
@scareything
Merge pull request #546 from szymonnogiec/#488-fix-authcode-opt
5dadbc0 
Fix --authcode option parsing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix --authcode option parsing. szymonnogiec/ziti-tunnel-sdk-c
3 participants
@qrkourier @szymonnogiec @gberl002