Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a Dockerfile for building a hosting tunneler image for Red Hat Linux #513

Merged
merged 6 commits into from
Oct 18, 2022
Merged

add a Dockerfile for building a hosting tunneler image for Red Hat Linux #513

merged 6 commits into from
Oct 18, 2022

Conversation

qrkourier
Copy link
Member

No description provided.

@qrkourier qrkourier self-assigned this Oct 9, 2022
@qrkourier qrkourier requested a review from a team as a code owner October 9, 2022 16:37
@qrkourier qrkourier linked an issue Oct 9, 2022 that may be closed by this pull request
Docker build with Red Hat Universal Base Image #512
Closed
scareything
scareything reviewed Oct 10, 2022
View reviewed changes
Copy link
Member

@scareything scareything left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR makes me realize that I'm not clear on what all of the docker files are in the /docker directory. Is there a place for some descriptions in the readme?

@qrkourier
Copy link
Member Author

This PR makes me realize that I'm not clear on what all of the docker files are in the /docker directory. Is there a place for some descriptions in the readme?

Good point. I'll re-write the Docker README to cover both Dockerfiles and their respective container images.

@qrkourier qrkourier force-pushed the issue-512-docker-build-redhat-ubi branch from c57fb1f to 12e0dce Compare October 10, 2022 15:32
@qrkourier
Copy link
Member Author

@scareything Here's the rendered view of the updated Docker README in this PR's branch: https://github.com/openziti/ziti-tunnel-sdk-c/tree/issue-512-docker-build-redhat-ubi/docker#readme

@qrkourier qrkourier merged commit 4a3b38b into main Oct 18, 2022
@qrkourier qrkourier deleted the issue-512-docker-build-redhat-ubi branch October 18, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scareything scareything scareything approved these changes

Assignees

@qrkourier qrkourier

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docker build with Red Hat Universal Base Image
2 participants
@qrkourier @scareything